From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: [PATCH][next] ALSA: vmaster: Use flex_array_size() helper in memcpy()
Date: Wed, 29 Jul 2020 17:18:29 -0500 [thread overview]
Message-ID: <20200729221829.GA10623@embeddedor> (raw)
Make use of the flex_array_size() helper to calculate the size of a
flexible array member within an enclosing structure.
This helper offers defense-in-depth against potential integer overflows
and makes it explicitly clear that we are dealing with a flexible array
member.
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
sound/core/vmaster.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/core/vmaster.c b/sound/core/vmaster.c
index ab36f9898711..21ce4082cb5f 100644
--- a/sound/core/vmaster.c
+++ b/sound/core/vmaster.c
@@ -262,7 +262,8 @@ int _snd_ctl_add_follower(struct snd_kcontrol *master,
return -ENOMEM;
srec->kctl = follower;
srec->follower = *follower;
- memcpy(srec->follower.vd, follower->vd, follower->count * sizeof(*follower->vd));
+ memcpy(srec->follower.vd, follower->vd, flex_array_size(srec, follower.vd,
+ srec->follower.count));
srec->master = master_link;
srec->flags = flags;
--
2.27.0
next reply other threads:[~2020-07-29 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 22:18 Gustavo A. R. Silva [this message]
2020-07-30 8:41 ` [PATCH][next] ALSA: vmaster: Use flex_array_size() helper in memcpy() Takashi Iwai
2020-07-30 13:12 ` Gustavo A. R. Silva
2020-07-30 14:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729221829.GA10623@embeddedor \
--to=gustavoars@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).