From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Jie Yang <yang.jie@linux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Sam McNally <sammc@chromium.org>, Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Stuart <daniel.stuart14@gmail.com>,
Yu-Hsuan Hsu <yuhsuan@chromium.org>,
Damian van Soelen <dj.vsoelen@gmail.com>
Subject: Re: [PATCH v2 2/2] ASoC: Intel: Add period size constraint on strago board
Date: Thu, 30 Jul 2020 16:49:37 +0300 [thread overview]
Message-ID: <20200730134937.GK3703480@smile.fi.intel.com> (raw)
In-Reply-To: <DM6PR11MB3642F476740FFDAB29C3B8DF97710@DM6PR11MB3642.namprd11.prod.outlook.com>
On Thu, Jul 30, 2020 at 01:23:57PM +0000, Lu, Brent wrote:
> > On Thu, Jul 30, 2020 at 04:13:35PM +0800, Brent Lu wrote:
> > > From: Yu-Hsuan Hsu <yuhsuan@chromium.org>
> > >
> > > The CRAS server does not set the period size in hw_param so ALSA will
> > > calculate a value for period size which is based on the buffer size
> > > and other parameters. The value may not always be aligned with Atom's
> > > dsp design so a constraint is added to make sure the board always has
> > > a good value.
> > >
> > > Cyan uses chtmax98090 and others(banon, celes, edgar, kefka...) use
> > > rt5650.
> >
> > Actually one more comment here.
> > Can you split per machine driver?
> >
>
> It adds constraints on BSW Chromebooks for same purpose. I don't see the
> benefit to split it.
I didn't get this.
Purpose of splitting this to two is to keep track on per driver basis what has
had happen there.
But it's minor and up to maintainers, of course.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-30 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 8:13 [PATCH v2 0/2] Add period size constraint for Atom Chromebook Brent Lu
2020-07-30 8:13 ` [PATCH v2 1/2] ASoC: intel: atom: Add period size constraint Brent Lu
2020-07-30 8:13 ` [PATCH v2 2/2] ASoC: Intel: Add period size constraint on strago board Brent Lu
2020-07-30 8:42 ` Andy Shevchenko
2020-07-30 13:23 ` Lu, Brent
2020-07-30 13:49 ` Andy Shevchenko [this message]
2020-07-30 8:41 ` [PATCH v2 0/2] Add period size constraint for Atom Chromebook Andy Shevchenko
2020-07-30 15:03 ` Takashi Iwai
2020-07-30 15:25 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730134937.GK3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.stuart14@gmail.com \
--cc=dj.vsoelen@gmail.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sammc@chromium.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yuhsuan@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).