From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org,
alsa-devel@alsa-project.org
Cc: Hyun Kwon <hyun.kwon@xilinx.com>,
Randy Dunlap <rdunlap@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Alexandre Bounine <alex.bou9@gmail.com>,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
Matt Porter <mporter@kernel.crashing.org>
Subject: [PATCH v2 3/3] drm: xlnx: dpsub: Fix DMADEVICES Kconfig dependency
Date: Fri, 31 Jul 2020 18:24:33 +0300 [thread overview]
Message-ID: <20200731152433.1297-4-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20200731152433.1297-1-laurent.pinchart@ideasonboard.com>
The dpsub driver uses the DMA engine API, and thus selects DMA_ENGINE to
provide that API. DMA_ENGINE depends on DMADEVICES, which can be
deselected by the user, creating a possibly unmet indirect dependency:
WARNING: unmet direct dependencies detected for DMA_ENGINE
Depends on [n]: DMADEVICES [=n]
Selected by [m]:
- DRM_ZYNQMP_DPSUB [=m] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=m] && OF [=y]
Add a dependency on DMADEVICES to fix this.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/gpu/drm/xlnx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig
index aa6cd889bd11..b52c6cdfc0b8 100644
--- a/drivers/gpu/drm/xlnx/Kconfig
+++ b/drivers/gpu/drm/xlnx/Kconfig
@@ -2,6 +2,7 @@ config DRM_ZYNQMP_DPSUB
tristate "ZynqMP DisplayPort Controller Driver"
depends on ARCH_ZYNQMP || COMPILE_TEST
depends on COMMON_CLK && DRM && OF
+ depends on DMADEVICES
select DMA_ENGINE
select DRM_GEM_CMA_HELPER
select DRM_KMS_CMA_HELPER
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-31 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 15:24 [PATCH v2 0/3] Fix Kconfig dependency issue with DMAENGINES selection Laurent Pinchart
2020-07-31 15:24 ` [PATCH v2 1/3] rapidio: Replace 'select' DMADEVICES 'with depends on' Laurent Pinchart
2020-07-31 15:24 ` [PATCH v2 2/3] ASoC: sh: " Laurent Pinchart
2020-07-31 15:24 ` Laurent Pinchart [this message]
2020-07-31 16:47 ` [PATCH v2 0/3] Fix Kconfig dependency issue with DMAENGINES selection Vinod Koul
2020-07-31 20:42 ` Laurent Pinchart
2020-08-02 6:44 ` Vinod Koul
2020-08-11 22:52 ` Laurent Pinchart
2020-08-12 3:59 ` Vinod Koul
2020-08-19 0:10 ` Laurent Pinchart
2020-07-31 18:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731152433.1297-4-laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alex.bou9@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=lgirdwood@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=mporter@kernel.crashing.org \
--cc=rdunlap@infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).