On Wed, Sep 30, 2020 at 03:50:47PM -0700, Dave Ertman wrote:

> +	ret = ancillary_device_initialize(ancildev);
> +	if (ret < 0) {
> +		dev_err(sdev->dev, "error: failed to initialize client dev %s\n", name);
> +		ida_simple_remove(client_ida, ancildev->id);
> +		goto err_free;
> +	}
> +
> +	return cdev;
> +
> +err_free:
> +	kfree(cdev);

It would be nice to have the ida_simple_remove() done in this unwind
section here too for consistency.

> +int sof_client_dev_register(struct snd_sof_dev *sdev, const char *name, struct ida *client_ida)
> +{

I know the hard limit on line length got raised but can we wrap this
please?