From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: alsa-devel@alsa-project.org, vkoul@kernel.org
Cc: vinod.koul@linaro.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, hui.wang@canonical.com,
srinivas.kandagatla@linaro.org, jank@cadence.com,
sanyog.r.kale@intel.com, rander.wang@linux.intel.com,
bard.liao@intel.com
Subject: [PATCH 0/5] soundwire: fix ACK/NAK handling and improve log
Date: Fri, 15 Jan 2021 13:37:33 +0800 [thread overview]
Message-ID: <20210115053738.22630-1-yung-chuan.liao@linux.intel.com> (raw)
The existing code reports a NAK only when ACK=0
This is not aligned with the SoundWire 1.x specifications.
Table 32 in the SoundWire 1.2 specification shows that a Device shall
not set NAK=1 if ACK=1. But Table 33 shows the Combined Response
may very well be NAK=1/ACK=1, e.g. if another Device than the one
addressed reports a parity error.
NAK=1 signals a 'Command_Aborted', regardless of the ACK bit value.
Move the tests for NAK so that the NAK=1/ACK=1 combination is properly
detected according to the specification.
Also, improve the demesg log to get more information for debugging.
Bard Liao (1):
soundwire: bus: add more details to track failed transfers
Pierre-Louis Bossart (4):
soundwire: use consistent format for Slave devID logs
soundwire: cadence: add status in dev_dbg 'State change' log
soundwire: cadence: fix ACK/NAK handling
soundwire: cadence: adjust verbosity in response handling
drivers/soundwire/bus.c | 11 ++++++-----
drivers/soundwire/cadence_master.c | 29 +++++++++++++++--------------
drivers/soundwire/slave.c | 10 ++++------
3 files changed, 25 insertions(+), 25 deletions(-)
--
2.17.1
next reply other threads:[~2021-01-15 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 5:37 Bard Liao [this message]
2021-01-15 5:37 ` [PATCH 1/5] soundwire: use consistent format for Slave devID logs Bard Liao
2021-01-15 5:37 ` [PATCH 2/5] soundwire: cadence: add status in dev_dbg 'State change' log Bard Liao
2021-01-15 5:37 ` [PATCH 3/5] soundwire: bus: add more details to track failed transfers Bard Liao
2021-01-15 5:37 ` [PATCH 4/5] soundwire: cadence: fix ACK/NAK handling Bard Liao
2021-01-15 5:37 ` [PATCH 5/5] soundwire: cadence: adjust verbosity in response handling Bard Liao
2021-01-19 14:58 ` [PATCH 0/5] soundwire: fix ACK/NAK handling and improve log Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115053738.22630-1-yung-chuan.liao@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).