On Mon, Feb 08, 2021 at 02:17:14PM +0000, Srinivas Kandagatla wrote: > + SOC_SINGLE_EXT("RX_Softclip Enable", SND_SOC_NOPM, 0, 1, 0, > + rx_macro_soft_clip_enable_get, > + rx_macro_soft_clip_enable_put), > + SOC_SINGLE_EXT("AUX_HPF Enable", SND_SOC_NOPM, 0, 1, 0, > + rx_macro_aux_hpf_mode_get, > + rx_macro_aux_hpf_mode_put), These are simple on/off controls so should end in Switch AFAICT. Otherwise this looks good.