From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <vkoul@kernel.org>, <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org,
Richard Fitzgerald <rf@opensource.cirrus.com>,
sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com
Subject: [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define
Date: Fri, 2 Dec 2022 16:18:09 +0000 [thread overview]
Message-ID: <20221202161812.4186897-1-rf@opensource.cirrus.com> (raw)
As determined by experimentation and asking a hardware person, the FIFO
in the Cadence IP is actually only 8 entries long, not 32. This is fixed
in patch #1.
As a bonus, patches #2 and #3 fix two other things I noticed while
debugging this.
Changes since v1:
- Rewrite commit message of patch #1
- Only reduce response_buf to 34 (32 + 2)
- Trim RX_FIFO_AVAIL to length of response_buf instead of expected
FIFO size
Richard Fitzgerald (3):
soundwire: cadence: Don't overflow the command FIFOs
soundwire: cadence: Remove wasted space in response_buf
soundwire: cadence: Drain the RX FIFO after an IO timeout
drivers/soundwire/cadence_master.c | 46 +++++++++++++++++++-----------
drivers/soundwire/cadence_master.h | 13 ++++++++-
2 files changed, 41 insertions(+), 18 deletions(-)
--
2.30.2
next reply other threads:[~2022-12-02 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 16:18 Richard Fitzgerald [this message]
2022-12-02 16:18 ` [PATCH v2 1/3] soundwire: cadence: Don't overflow the command FIFOs Richard Fitzgerald
2022-12-02 16:18 ` [PATCH v2 2/3] soundwire: cadence: Remove wasted space in response_buf Richard Fitzgerald
2022-12-02 16:18 ` [PATCH v2 3/3] soundwire: cadence: Drain the RX FIFO after an IO timeout Richard Fitzgerald
2022-12-02 17:10 ` [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define Pierre-Louis Bossart
2023-01-09 16:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202161812.4186897-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).