alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>,
	ALSA development <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [alsa-devel] UCM extensions
Date: Tue, 5 Nov 2019 13:52:45 -0600	[thread overview]
Message-ID: <2598c6a8-ce64-ad7e-ee34-8ea930b3cf7d@linux.intel.com> (raw)
In-Reply-To: <6dcc3e0d-0df5-90cf-220f-59253d3b5c7c@perex.cz>



On 11/5/19 1:36 PM, Jaroslav Kysela wrote:
> Hi all,
> 
>      I make some internal ucm code cleanups in alsa-lib and added three 
> major extensions to allow more complex configurations which we require 
> for the SOF kernel driver.

Great, thanks for working on this!

> 
>      The first thing is the added substitution for the value strings:
> 
> https://github.com/alsa-project/alsa-lib/commit/f1e637b285e8e04e6761248a070f58f3a8fde6fc 
> 
> 
>      The second thing is the If block:
> 
> https://github.com/alsa-project/alsa-lib/commit/985715ce8148dc7ef62c8e3d8ce5a0c2ac51f8df 

is it possible for the Condition to check if the card contains the SOF 
prefix?

For Baytrail/Cherrytrail support, we have a ton of existing UCM files, 
and the only thing needed is e.g.
- to change from hw:bytcrrt5640 to hw:sofbytcrt5640
- make the controls for the legacy driver conditional

SectionVerb {
	EnableSequence [
		
		if (card name does not contain SOF)
		<platforms/bytcr/PlatformEnableSeq.conf>
		endif
		<codecs/rt5640/EnableSeq.conf>
	]

Most of the information that matters for those UCM files is the type of 
peripherals and the matching mixer configuration for the codec driver, 
and we should reuse this information between legacy and SOF.

> 
>      The third thing is the card / hardware like specifier passed as the 
> ucm name to snd_use_case_mgr_open() to support multiple card instances:
> 
> https://github.com/alsa-project/alsa-lib/commit/60164fc5886cdc6ca55eeed0c2e3f751a7d2b2c0 
> 
> 
>      All those patches (with other cleanups) are in the ucm2 branch on 
> github for comments:
> 
> https://github.com/alsa-project/alsa-lib/commits/ucm2
> 
>      The proposed SOF UCM config diff is here:
> 
> https://github.com/alsa-project/alsa-ucm-conf/commit/723b6da881721488229154e923ed36413955a051 
> 
> https://github.com/alsa-project/alsa-ucm-conf/commits/ucm2
> 
>      I added everything to keep the interface backward compatible, so 
> the current applications should not observe any different behavior. The 
> applications like pulseaudio should use the 'hw:CARD_INDEX' specifier 
> for the open call in the future and snd_use_case_parse_ctl_elem_id() 
> helper for the element control names.
> 
>      If you have another ideas to address those issues, please, let me 
> know.
> 
>      BTW, Mark: The SOF UCM configs relies on the driver name changes, 
> so it might be worth to send "ASoC: intel - fix the card names" patch to 
> 5.4 to make things stable more quickly:
> 
>      https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.5&id=d745cc1ab65945b2d17ec9c5652f38299c054649
> 
>                  Thanks,
>                      Jaroslav
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-11-05 19:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 19:36 [alsa-devel] UCM extensions Jaroslav Kysela
2019-11-05 19:52 ` Pierre-Louis Bossart [this message]
2019-11-05 20:19   ` Jaroslav Kysela
2019-11-05 20:27     ` Pierre-Louis Bossart
2019-11-06 11:50 ` Kai Vehmanen
2019-11-06 13:10   ` Jaroslav Kysela
2019-11-06 13:51     ` Jaska Uimonen
2019-11-06 17:04       ` Jaroslav Kysela
2019-11-07  6:48 ` Takashi Iwai
2019-11-07  8:33   ` Jaroslav Kysela
2019-11-07  9:23     ` Takashi Iwai
2019-11-07 11:08       ` Jaroslav Kysela
2019-11-07 11:16         ` Takashi Iwai
2019-11-07 13:14           ` Jaroslav Kysela
2019-11-07 10:18 ` Cezary Rojewski
2019-11-07 11:01   ` Jaroslav Kysela
2019-11-07 11:54     ` Kai Vehmanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2598c6a8-ce64-ad7e-ee34-8ea930b3cf7d@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).