From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Jie Yang <yang.jie@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Hans de Goede <hdegoede@redhat.com>,
Gu Shengxian <gushengxian@yulong.com>
Subject: Re: [PATCH 1/5] ASoC: soc-dai: update snd_soc_dai_delay() to snd_soc_pcm_dai_delay()
Date: Mon, 29 Nov 2021 09:42:34 -0600 [thread overview]
Message-ID: <2cd48411-4be6-196f-025d-74fd3a5266dc@linux.intel.com> (raw)
In-Reply-To: <YaDqo6MC8/zjhpoh@sirena.org.uk>
On 11/26/21 8:09 AM, Mark Brown wrote:
> On Thu, Nov 25, 2021 at 11:41:38PM +0000, Kuninori Morimoto wrote:
>
>> Sorry for my late response.
>> (It was PC replace week)
>
> No worries, hope the new PC is working well!
>
>>>> I would think it's more accurate to update the delay information while
>>>> dealing with the hw_ptr update, no?
>
>>> Morimoto-san?
>
>> I think your opinion is very correct.
>> But this patch-set is for "cleanup/refactoring",
>> and your opinion is for "add new feature", I think.
>
> Hrm, right - this isn't making anything better or worse in terms of the
> accuracy, it's just moving things around so Pierre's suggestion is a
> separate thing.
Indeed, I misunderstood the series are removing the update of the
runtime->delay field while updating the hw_ptr, but this is only
shuffling code around. This is still updating both avail/delay in the
same manner so no objections. Sorry for the noise.
next prev parent reply other threads:[~2021-11-29 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 7:44 [PATCH 0/5] ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method Kuninori Morimoto
2021-11-16 7:45 ` [PATCH 1/5] ASoC: soc-dai: update snd_soc_dai_delay() to snd_soc_pcm_dai_delay() Kuninori Morimoto
2021-11-16 20:43 ` Pierre-Louis Bossart
2021-11-25 16:39 ` Mark Brown
2021-11-25 23:41 ` Kuninori Morimoto
2021-11-26 14:09 ` Mark Brown
2021-11-29 15:42 ` Pierre-Louis Bossart [this message]
2021-11-16 7:45 ` [PATCH 2/5] ASoC: soc-component: add snd_soc_pcm_component_delay() Kuninori Morimoto
2021-11-16 7:45 ` [PATCH 3/5] ASoC: amd: acp-pcm-dma: add .delay support Kuninori Morimoto
2021-11-16 7:45 ` [PATCH 4/5] ASoC: intel: sst-mfld-platform-pcm: " Kuninori Morimoto
2021-11-16 7:45 ` [PATCH 5/5] ASoC: soc-pcm: tidyup soc_pcm_pointer()'s delay update method Kuninori Morimoto
2021-11-29 15:43 ` [PATCH 0/5] " Pierre-Louis Bossart
2021-11-29 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd48411-4be6-196f-025d-74fd3a5266dc@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=gushengxian@yulong.com \
--cc=hdegoede@redhat.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).