From: Rohit Kumar <rohitkr@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, linux-arm-msm@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/8] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node
Date: Thu, 9 Jul 2020 15:42:38 +0530 [thread overview]
Message-ID: <40ca93fe-5bf0-ace3-4f95-90624d29a409@codeaurora.org> (raw)
In-Reply-To: <de07f84b-40bc-d9ae-932d-623a5e8341e2@linaro.org>
On 7/9/2020 3:38 PM, Srinivas Kandagatla wrote:
>
>
> On 09/07/2020 11:01, Rohit Kumar wrote:
>>
>> On 7/9/2020 2:57 PM, Srinivas Kandagatla wrote:
>>>
>>>
>>> On 08/07/2020 06:08, Rohit kumar wrote:
>>>> Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
>>>>
>>>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>>>> ---
>>>> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
>>>> b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
>>>> index 32c2cdb..04e34cc 100644
>>>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
>>>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
>>>> @@ -4,7 +4,8 @@ This node models the Qualcomm Technologies
>>>> Low-Power Audio SubSystem (LPASS).
>>>> Required properties:
>>>> -- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu"
>>>> +- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu" or
>>>> + "qcom,lpass-cpu-sc7180"
>>>> - clocks : Must contain an entry for each entry in
>>>> clock-names.
>>>> - clock-names : A list which must include the following
>>>> entries:
>>>> * "ahbix-clk"
>>>
>>> Can you also list the clocks that are mandatory for this SoC.
>>>
>>> --srini
>>>
>> Will it be fine if I update it in patch 8 only where we have moved to
>> yaml format?
>>
> May be reverse the order, Convert to Yaml first and then add sc7180!
Actually Mark suggested to keep yaml change at the end of patch series
as there
are pending yaml patch reviews and it might take time. If we keep yaml
change before sc7180
change, then it will get blocked until yaml review. For now, I can
update in exisiting
documentation. Please suggest.
Thanks
>
> --srini
>> Thanks,
>>
>> Rohit
>>
>>>
>>>>
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.
next prev parent reply other threads:[~2020-07-09 10:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 5:08 [PATCH v3 0/8] ASoC: qcom: Add support for SC7180 lpass variant Rohit kumar
2020-07-08 5:08 ` [PATCH v3 1/8] ASoC: qcom: Add common array to initialize soc based core clocks Rohit kumar
2020-07-09 9:26 ` Srinivas Kandagatla
2020-07-08 5:08 ` [PATCH v3 2/8] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function Rohit kumar
2020-07-09 9:26 ` Srinivas Kandagatla
2020-07-08 5:08 ` [PATCH v3 3/8] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers Rohit kumar
2020-07-09 9:26 ` Srinivas Kandagatla
2020-07-09 9:57 ` Rohit Kumar
2020-07-09 10:06 ` Srinivas Kandagatla
2020-07-09 10:14 ` Rohit Kumar
2020-07-08 5:08 ` [PATCH v3 4/8] include: dt-bindings: sound: Add sc7180-lpass bindings header Rohit kumar
2020-07-08 14:45 ` Mark Brown
2020-07-09 10:06 ` Rohit Kumar
2020-07-08 5:08 ` [PATCH v3 5/8] ASoC: qcom: lpass-platform: Replace card->dev with component->dev Rohit kumar
2020-07-08 16:50 ` Mark Brown
2020-07-09 3:46 ` Rohit Kumar
2020-07-09 9:26 ` Srinivas Kandagatla
2020-07-08 5:08 ` [PATCH v3 6/8] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node Rohit kumar
2020-07-09 9:27 ` Srinivas Kandagatla
2020-07-09 10:01 ` Rohit Kumar
2020-07-09 10:08 ` Srinivas Kandagatla
2020-07-09 10:12 ` Rohit Kumar [this message]
2020-07-09 10:14 ` Srinivas Kandagatla
2020-07-09 10:34 ` Mark Brown
2020-07-08 5:08 ` [PATCH v3 7/8] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar
2020-07-09 9:27 ` Srinivas Kandagatla
2020-07-08 5:08 ` [PATCH v3 8/8] dt-bindings: sound: lpass-cpu: Move to yaml format Rohit kumar
2020-07-13 22:53 ` Rob Herring
2020-07-22 10:44 ` Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ca93fe-5bf0-ace3-4f95-90624d29a409@codeaurora.org \
--to=rohitkr@codeaurora.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).