alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH RFC] ASoC: amlogic: do not use dpcm_playback/capture flags
Date: Tue, 14 May 2024 23:11:03 +0000	[thread overview]
Message-ID: <87seyk2dmh.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <46daae9b-10dc-4f49-8a25-c387d03ae87a@sirena.org.uk>


Hi

> > dpcm_playback/capture flags are being deprecated in ASoC.
> > Use playback/capture_only flags instead
> > 
> > Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > 
> > Following Kuninori's series, dpcm_playback/capture will be ignored.
> > However, properly disabling stream direction is important for Amlogic
> > audio drivers.
> > 
> > I'm not too sure how this should be applied to avoid breaking bisect,
> > before or after Kuninori's series. Maybe it should be merged into it ?
> 
> Probably better to integrate it I think?

ASoC needs dpcm_xxx flag *before* my patch.
Your patch is replacing it to xxx_only flag, so it should be applied
*after* my patch. So integrate/merge is good idea, I think.

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto

  reply	other threads:[~2024-05-14 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13  0:31 [PATCH v2 0/3] ASoC: grace time for DPCM cleanup Kuninori Morimoto
2024-05-13  0:31 ` [PATCH v2 1/3] ASoC: soc-pcm: Indicate warning if dpcm_playback/capture were used for availability limition Kuninori Morimoto
2024-05-13  0:31 ` [PATCH v2 2/3] ASoC: soc-pcm: Indicate warning if CPU / Codec availability mismatch Kuninori Morimoto
     [not found]   ` <b9cc6106-4f5e-4fd5-b5f4-bc3ed6fbe300@linux.intel.com>
2024-05-19 23:11     ` Kuninori Morimoto
2024-05-13  0:31 ` [PATCH v2 3/3] ASoC: remove snd_soc_dai_link_set_capabilities() Kuninori Morimoto
2024-05-14 14:30 ` [PATCH RFC] ASoC: amlogic: do not use dpcm_playback/capture flags Jerome Brunet
2024-05-14 14:45   ` Mark Brown
2024-05-14 23:11     ` Kuninori Morimoto [this message]
2024-05-15 13:01       ` Jerome Brunet
2024-05-14 14:31 ` [PATCH v2 0/3] ASoC: grace time for DPCM cleanup Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87seyk2dmh.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).