From: Phil Burk <philburk@google.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Baolin Wang <baolin.wang@linaro.org>,
Takashi Iwai <tiwai@suse.de>, Zach Riggle <riggle@google.com>,
Mark Brown <broonie@kernel.org>, Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation
Date: Thu, 7 Feb 2019 09:41:03 -0800 [thread overview]
Message-ID: <CACL=Q7wpCJiiHoWE7FrArpm0DFYKUkLdPkUg+uh9=oOMPWWWMA@mail.gmail.com> (raw)
In-Reply-To: <20190204093910.23878-1-perex@perex.cz>
Thanks for these patches for tinyalsa. Looks great!
I made a few minor comments on the code layout.
https://github.com/perexg/tinyalsa/commit/f62b953f37693e8426ee4c20e53baae757ba1026
Can you see them?
Phil Burk
On Mon, Feb 4, 2019 at 1:39 AM Jaroslav Kysela <perex@perex.cz> wrote:
> This patchset contains the anonymous dup implementation with permissions
> checking for the ALSA's PCM interface in kernel to enable the restricted
> DMA sound buffer sharing for the restricted tasks.
>
> The code was tested through qemu and it seems to be pretty stable.
>
> The initial tinyalsa implementation can be found here:
>
> https://github.com/perexg/tinyalsa/commits/anondup
>
> v2 of the patches:
>
> - change clone parameter to subdevice number for the pcm attach
> - change SNDRV_PCM_PERM_MAX to SNDRV_PCM_PERM_MASK
> - the tinyalsa implementation was a little updated (restructured)
>
> v3 of the patches:
>
> - group integer declarations in snd_pcm_anonymous_dup()
> - replaced substream->pcm with pcm in snd_pcm_anonymous_dup()
> - added SNDRV_PCM_PERM_RW check for read/write/readv/writev syscalls
>
> v4 of the patches:
>
> - more simple restriction control (only two modes - full/buffer)
> - the tinyalsa implementation follows this change
>
> Cc: Phil Burk <philburk@google.com>
> Cc: Zach Riggle <riggle@google.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: Baolin Wang <baolin.wang@linaro.org>
>
> Jaroslav Kysela (2):
> ALSA: pcm: implement the anonymous dup (inode file descriptor)
> ALSA: pcm: implement the mmap buffer mode for the anonymous dup
>
> include/sound/pcm.h | 10 +++--
> include/uapi/sound/asound.h | 6 ++-
> sound/core/oss/pcm_oss.c | 2 +-
> sound/core/pcm.c | 13 +++---
> sound/core/pcm_compat.c | 1 +
> sound/core/pcm_native.c | 97
> ++++++++++++++++++++++++++++++++++++++++++---
> 6 files changed, 110 insertions(+), 19 deletions(-)
>
> --
> 2.13.6
>
next prev parent reply other threads:[~2019-02-07 17:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 9:39 [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation Jaroslav Kysela
2019-02-04 9:39 ` [PATCH 1/2] ALSA: pcm: implement the anonymous dup (inode file descriptor) Jaroslav Kysela
2019-02-04 9:39 ` [PATCH 2/2] ALSA: pcm: implement the mmap buffer mode for the anonymous dup Jaroslav Kysela
2019-02-04 10:48 ` Takashi Iwai
2019-02-07 17:41 ` Phil Burk [this message]
2019-02-07 17:53 ` [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation Jaroslav Kysela
2019-02-08 15:57 ` Phil Burk
2019-03-26 14:09 ` Mark Brown
2019-03-26 14:13 ` Takashi Iwai
2019-03-26 14:27 ` Phil Burk
2019-03-26 14:41 ` Jaroslav Kysela
2019-04-23 18:08 ` Takashi Iwai
2019-04-23 20:11 ` Phil Burk
2019-04-23 20:25 ` Takashi Iwai
2020-06-08 13:45 ` Mark Brown
2020-06-08 17:49 ` Phil Burk
2020-06-10 23:10 ` Phil Burk
2020-06-12 16:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACL=Q7wpCJiiHoWE7FrArpm0DFYKUkLdPkUg+uh9=oOMPWWWMA@mail.gmail.com' \
--to=philburk@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=leo.yan@linaro.org \
--cc=perex@perex.cz \
--cc=riggle@google.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).