From: Cheng-yi Chiang <cychiang@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Tzung-Bi Shih <tzungbi@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Hung-Te Lin <hungte@chromium.org>,
"M R, Sathya Prakash" <sathya.prakash.m.r@intel.com>,
Mark Brown <broonie@kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Shuming Fan <shumingf@realtek.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Dylan Reid <dgreid@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [alsa-devel] [PATCH v2] firmware: vpd: Add an interface to read VPD value
Date: Tue, 8 Oct 2019 20:10:21 +0800 [thread overview]
Message-ID: <CAFv8NwL2xRFUSRwiD4=mPg1zWm0gmzUQmhaU9SKCdc+=r7pjrg@mail.gmail.com> (raw)
In-Reply-To: <20191008120649.GC2761030@kroah.com>
On Tue, Oct 8, 2019 at 8:06 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Oct 08, 2019 at 06:11:44PM +0800, Cheng-Yi Chiang wrote:
> > Add an interface for other driver to query VPD value.
> > This will be used for ASoC machine driver to query calibration
> > data stored in VPD for smart amplifier speaker resistor
> > calibration.
> >
> > The example usage in ASoC machine driver is like:
> >
> > #define DSM_CALIB_KEY "dsm_calib"
> > static int load_calibration_data(struct cml_card_private *ctx) {
> > char *data = NULL;
> > int ret;
> > u32 value_len;
> >
> > /* Read calibration data from VPD. */
> > ret = vpd_attribute_read(1, DSM_CALIB_KEY,
> > (u8 **)&data, &value_len);
> >
> > /* Parsing of this string...*/
> > }
> >
> >
> > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> > ---
>
> I can't take this patch without a real user of this function in the
> kernel tree at the same time. Please submit it as part of a patch
> series with that change as well.
>
Hi Greg,
I see.
There is an ongoing discussion with Mark in
https://patchwork.kernel.org/patch/11179237/
I will resend this after machine driver is merged, and after codec
driver change get sorted out there.
Thanks!
> thanks,
>
> greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-10-08 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 10:11 [alsa-devel] [PATCH v2] firmware: vpd: Add an interface to read VPD value Cheng-Yi Chiang
2019-10-08 12:06 ` Greg Kroah-Hartman
2019-10-08 12:10 ` Cheng-yi Chiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFv8NwL2xRFUSRwiD4=mPg1zWm0gmzUQmhaU9SKCdc+=r7pjrg@mail.gmail.com' \
--to=cychiang@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hungte@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=seanpaul@chromium.org \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).