Re: [alsa-devel] [RFC 06/15] ASoC: bdw-rt5677: Add a DAI link for rt5677 SPI PCM device

From: Curtis Malainey <cujomalainey@google.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	ALSA development <alsa-devel@alsa-project.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Ben Zhang <benzh@chromium.org>, Mark Brown <broonie@kernel.org>,
	Steve Winslow <swinslow@gmail.com>,
	Curtis Malainey <cujomalainey@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>
Subject: Re: [alsa-devel] [RFC 06/15] ASoC: bdw-rt5677: Add a DAI link for rt5677 SPI PCM device
Date: Mon, 9 Sep 2019 09:53:21 -0700	[thread overview]
Message-ID: <CAOReqxh3BLCnJOJJbTcbBv83r2yF8_Df7d_Z6bg=3V+qnHPeDw@mail.gmail.com> (raw)
In-Reply-To: <87y2yy5nl8.wl-kuninori.morimoto.gx@renesas.com>

On Sun, Sep 8, 2019 at 5:18 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Curtis
>
> > From: Ben Zhang <benzh@chromium.org>
> >
> > This link is needed for the RT5677 DSP to do hotwording
> >
> > Signed-off-by: Ben Zhang <benzh@chromium.org>
> > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> > ---
> (snip)
> > +/* Wake on voice interface */
> > +SND_SOC_DAILINK_DEF(fe_dsp,
> > +     DAILINK_COMP_ARRAY(COMP_CPU("spi-RT5677AA:00")));
> > +
> > +SND_SOC_DAILINK_DEF(platform_dsp,
> > +     DAILINK_COMP_ARRAY(COMP_PLATFORM("spi-RT5677AA:00")));
> > +
> > +SND_SOC_DAILINK_DEF(be_dsp,
> > +     DAILINK_COMP_ARRAY(COMP_CODEC("i2c-RT5677CE:00", "rt5677-dspbuffer")));
> > +
> (snip)
> > +     /* Non-DPCM links */
> > +     {
> > +             .name = "Codec DSP",
> > +             .stream_name = "Wake on Voice",
> > +             SND_SOC_DAILINK_REG(fe_dsp, be_dsp, platform_dsp),
> > +     },
>
> If you don't need to re-use CPU/Codec/Platform definition,
> I guess you can use more short version?
>
> SND_SOC_DAILINK_DEFS(dsp,
>         DAILINK_COMP_ARRAY(COMP_CPU("spi-RT5677AA:00")),
>         DAILINK_COMP_ARRAY(COMP_CODEC("i2c-RT5677CE:00", "rt5677-dspbuffer")),
>         DAILINK_COMP_ARRAY(COMP_PLATFORM("spi-RT5677AA:00")));
>
>  struct snd_soc_dai_link link = {
>         ...
>         SND_SOC_DAILINK_REG(dsp),
>  };
>
Updated, thanks!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel