alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>
To: Hui Wang <hui.wang@canonical.com>, Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: [PATCH v2] ASoC: amd: put off registering mach platform_dev to avoid -517 err
Date: Fri, 22 May 2020 14:30:47 +0000	[thread overview]
Message-ID: <DM6PR12MB26335DA69D595C332A20779697B40@DM6PR12MB2633.namprd12.prod.outlook.com> (raw)
In-Reply-To: <0acc99c4-6fe0-b613-4af2-5439ecd8981b@canonical.com>

[AMD Official Use Only - Internal Distribution Only]



> -----Original Message-----
> From: Hui Wang <hui.wang@canonical.com>
> Sent: Friday, May 22, 2020 7:27 PM
> To: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Mark Brown
> <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
> Subject: Re: [PATCH v2] ASoC: amd: put off registering mach platform_dev to
> avoid -517 err
> 
> 
> On 2020/5/22 下午8:59, Hui Wang wrote:
> >
> > On 2020/5/22 下午7:28, Mukunda, Vijendar wrote:
> >>
> >>> -----Original Message-----
> >>> From: Mark Brown <broonie@kernel.org>
> >>> Sent: Friday, May 22, 2020 4:52 PM
> >>> To: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>
> >>> Cc: Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org
> >>> Subject: Re: [PATCH v2] ASoC: amd: put off registering mach
> >>> platform_dev to
> >>> avoid -517 err
> >>>
> >>> On Fri, May 22, 2020 at 11:13:43AM +0000, Mukunda, Vijendar wrote:
> >>>
> >>>> Does sound card registration failure at boot time due to modules
> >>>> loading
> >>> order can be considered as bug ?
> >>>
> >>> No, this is totally normal.  If it failed to bind ever then that'd be a
> >>> problem but this is just deferring.
> >> In that case, we don't need this work around I guess.
> >> At maximum during boot time, we may see few sound card registration
> >> failure logs,
> >> Which is normal.
> >>
> >> With this change, our concept of ACP parent device which will create
> >> platform devices
> >> for DMA driver, Generic DMIC driver and Machine driver will be changed.
> >> We implemented same design for Raven I2S driver as well which got
> >> productized.
> >>
> > OK, got it.  It doesn't affect the sound function anyway.
> 
> BTW, so far, I have not seen the -517 error from ubuntu kernel dmesg on
> PC or laptop. Maybe this is the 1st driver to print this error in the
> dmesg on PC or laptop, so I guess it probably confuses the users or our QA.
> 

We have similar design for I2S endpoint which got productized on other OS
variant.
Most of the PC and Laptop comes up with Legacy HD Audio Driver solution.
This is ASoC based driver.
As this failure message only appears during boot time,  Its okay to go ahead.
End user should really worry if sound card is not created even after system
boots up.

  reply	other threads:[~2020-05-22 14:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  8:17 [PATCH v2] ASoC: amd: put off registering mach platform_dev to avoid -517 err Hui Wang
2020-05-22  9:16 ` Mukunda, Vijendar
2020-05-22 11:08 ` Mark Brown
2020-05-22 11:13   ` Mukunda, Vijendar
2020-05-22 11:22     ` Mark Brown
2020-05-22 11:28       ` Mukunda, Vijendar
2020-05-22 12:59         ` Hui Wang
2020-05-22 13:57           ` Hui Wang
2020-05-22 14:30             ` Mukunda, Vijendar [this message]
2020-05-22 15:14               ` Mukunda, Vijendar
2020-05-22 15:32                 ` Mark Brown
2020-05-23  0:11                   ` Mukunda, Vijendar
2020-05-25  3:32                     ` Hui Wang
2020-05-22 19:10 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB26335DA69D595C332A20779697B40@DM6PR12MB2633.namprd12.prod.outlook.com \
    --to=vijendar.mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=hui.wang@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).