Re: [alsa-devel] [PATCH v3] ALSA: hda: add Intel DSP configuration / probe code

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
>>> +	{
>>> +		.flags = FLAG_SOF,
>>
>> can we have more than one table per PCI ID? e.g. in this case it'd be
>> good to have the DMIC case separate from Google.
> 
> Yes, first match wins. So we need to add flags = FLAG_SOF |
> FLAG_SOF_ONLY_IF_DMIC entry bellow the dmi exceptions for device == 0x3198, too?

I need to check this, I am not sure if the firmware (Coreboot or Legacy) 
includes the NHLT definitions.
> 
>>
>>> +		.device = 0x3198,
>>> +		.dmi_table = (const struct dmi_system_id []) {
>>> +			{
>>> +				.ident = "Google Chromebooks",
>>> +				.matches = {
>>> +					DMI_MATCH(DMI_SYS_VENDOR, "Google"),
>>> +				}
>>> +			},
>>> +			{}
>>> +		}
>>> +	},
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_INTEL_GLK)
>>
>> should it be elif, as done for CometLake/CML?
> 
> I though that the SST driver is the default for 0x3198. Or the legacy driver
> is in the game, too? If yes, we need to add conditional SST entries.

I am not aware of any GLK platform where the SST driver is required.

let me work off-line on a list of quirks that are needed.

> 
>>> +	{
>>> +		.flags = FLAG_SST,
>>> +		.device = 0x3198,
>>> +	},
>>> +#endif
>>> +/* Icelake */
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_ICELAKE)
>>> +	{
>>> +		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
>>> +		.device = 0x34c8,
>>> +	},
>>> +#endif
>>> +/* Elkhart Lake */
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_ELKHARTLAKE)
>>> +	{
>>> +		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
>>> +		.device = 0x4b55,
>>> +	},
>>> +#endif
>>> +/* Appololake (Broxton-P) */
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
>>> +	{
>>> +		.flags = FLAG_SOF,
>>> +		.device = 0x5a98,
>>> +		.dmi_table = (const struct dmi_system_id []) {
>>> +			{
>>> +				.ident = "Up Squared",
>>> +				.matches = {
>>> +					DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
>>> +					DMI_MATCH(DMI_BOARD_NAME, "UP-APL01"),
>>> +				}
>>> +			},
>>> +			{}
>>> +		}
>>> +	},
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_INTEL_APL)
>>
>> elif?
> 
> Same. What's the default driver for APL?

Should be legacy except for Chromebooks where it's SST.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel