Re: [alsa-devel] [PATCH] ASoC: rt711: add rt711 codec driver - Pierre-Louis Bossart

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: shumingf@realtek.com, broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, jack.yu@realtek.com,
	alsa-devel@alsa-project.org, lars@metafoo.de,
	Vinod Koul <vkoul@kernel.org>,
	derek.fang@realtek.com, flove@realtek.com, bard.liao@intel.com,
	pierre-louis.bossart@intel.com
Subject: Re: [alsa-devel] [PATCH] ASoC: rt711: add rt711 codec driver
Date: Thu, 2 Jan 2020 14:37:52 -0600	[thread overview]
Message-ID: <ae09b3aa-952a-569f-e321-269dfde372be@linux.intel.com> (raw)
In-Reply-To: <20191227054445.27223-1-shumingf@realtek.com>

On 12/26/19 11:44 PM, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> This is the initial codec driver for rt711.
> 
> Signed-off-by: Shuming Fan <shumingf@realtek.com>

Thanks Shuming.

I will add my own

Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

tag, but this driver was also tested by others at Intel, including Bard 
Liao and Rander Wang, on CometLake, IceLake and TigerLake platforms. I 
am not aware of any issues with this codec, and jack detection was 
tested extensively.

The key point to be reviewed is the use of regmap, where we disable 
access to the registers until the device becomes ATTACHED (cache-only), 
and also make sure hw calibration is rerun (cache-bypass) before 
restoring settings in the resume step.

This patch also depends on interface changes on the SoundWire side, see 
below what Vinod provided before the holiday break
-Pierre

The following changes since commit e42617b825f8073569da76dc4510bfa019b1c35a:

   Linux 5.5-rc1 (2019-12-08 14:57:55 -0800)

are available in the Git repository at:

   git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git 
tags/sdw_interfaces_5.6

for you to fetch changes up to 09f6a72d014386939d21899921dd379006471a4b:

   soundwire: intel: add clock stop quirks (2019-12-12 09:17:07 +0530)

----------------------------------------------------------------
SoundWire tag for ASoC

This contains the recently merged soundwire interface changes for ASoC
subsystem.

----------------------------------------------------------------
Bard Liao (2):
       soundwire: intel: update headers for interrupts
       soundwire: intel: add link_list to handle interrupts with a 
single thread

Pierre-Louis Bossart (7):
       soundwire: sdw_slave: add probe_complete structure and new fields
       soundwire: sdw_slave: add enumeration_complete structure
       soundwire: sdw_slave: add initialization_complete definition
       soundwire: sdw_slave: track unattach_request to handle all init 
sequences
       soundwire: intel: update interfaces between ASoC and SoundWire
       soundwire: intel: add mutex for shared SHIM register access
       soundwire: intel: add clock stop quirks

Rander Wang (2):
       soundwire: intel: update stream callbacks for hwparams/free 
stream operations
       soundwire: intel: add prototype for WAKEEN interrupt processing

  drivers/soundwire/intel.c           |  20 ++++++++++++++------
  drivers/soundwire/intel.h           |  13 ++++++++-----
  drivers/soundwire/intel_init.c      |  32 ++++++++------------------------
  include/linux/soundwire/sdw.h       |  19 +++++++++++++++++++
  include/linux/soundwire/sdw_intel.h | 156 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
  5 files changed, 196 insertions(+), 44 deletions(-)

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel