From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Akshu.Agrawal@amd.com, Mark Brown <broonie@kernel.org>,
djkurtz@google.com, Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [RESEND PATCH v2 7/7] ASoC: amd: Added ACP3x system resume and runtime pm ops
Date: Wed, 6 Nov 2019 10:43:42 -0600 [thread overview]
Message-ID: <c30bea61-8db4-fb7a-bead-c665f88b3091@linux.intel.com> (raw)
In-Reply-To: <1573137364-5592-8-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
On 11/7/19 8:36 AM, Ravulapati Vishnu vardhan rao wrote:
> When system wide suspend happens, ACP will be powered off
> and when system resumes,for audio usecase to continue,
> all the runtime configuration data needs to be programmed again.
> Added resume pm call back to ACP pm ops and
> also Added runtime PM operations for ACP3x PCM platform device.
> Device will enter into D3 state when there is no activity
> on audio I2S lines.
spaces after punctuation and use of capital letters at the start of a
sentence?
>
> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
> ---
> sound/soc/amd/raven/pci-acp3x.c | 47 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 46 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
> index 7727c9d..d567585 100644
> --- a/sound/soc/amd/raven/pci-acp3x.c
> +++ b/sound/soc/amd/raven/pci-acp3x.c
> @@ -9,6 +9,9 @@
> #include <linux/io.h>
> #include <linux/platform_device.h>
> #include <linux/interrupt.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/delay.h>
> +#include <sound/pcm.h>
>
> #include "acp3x.h"
>
> @@ -247,6 +250,11 @@ static int snd_acp3x_probe(struct pci_dev *pci,
> }
> break;
> }
> + pm_runtime_set_autosuspend_delay(&pci->dev, 10000);
> + pm_runtime_use_autosuspend(&pci->dev);
> + pm_runtime_set_active(&pci->dev);
> + pm_runtime_put_noidle(&pci->dev);
> + pm_runtime_enable(&pci->dev);
> return 0;
>
> unmap_mmio:
> @@ -268,6 +276,39 @@ static int snd_acp3x_probe(struct pci_dev *pci,
> return ret;
> }
>
> +static int snd_acp3x_suspend(struct device *dev)
> +{
> + int status;
> + struct acp3x_dev_data *adata = dev_get_drvdata(dev);
> +
> + status = acp3x_deinit(adata->acp3x_base);
> + if (status)
> + dev_err(dev, "ACP de-init failed\n");
> + else
> + dev_info(dev, "ACP de-initialized\n");
> +
> + return 0;
> +}
> +static int snd_acp3x_resume(struct device *dev)
> +{
> + int status;
> + struct acp3x_dev_data *adata = dev_get_drvdata(dev);
> +
> + status = acp3x_init(adata->acp3x_base);
> + if (status) {
> + dev_err(dev, "ACP init failed\n");
> + return status;
> + }
> +
> + return 0;
> +}
> +
> +static const struct dev_pm_ops acp3x_pm = {
> + .runtime_suspend = snd_acp3x_suspend,
> + .runtime_resume = snd_acp3x_resume,
> + .resume = snd_acp3x_resume,
> +};
that should have been combined with the previous patch, you resume inits
in the platform device resume and only add it to the PCI level here.
> +
> static void snd_acp3x_remove(struct pci_dev *pci)
> {
> int i, ret;
> @@ -283,7 +324,8 @@ static void snd_acp3x_remove(struct pci_dev *pci)
> else
> dev_info(&pci->dev, "ACP de-initialized\n");
> iounmap(adata->acp3x_base);
> -
> + pm_runtime_disable(&pci->dev);
> + pm_runtime_get_noresume(&pci->dev);
> pci_disable_msi(pci);
> pci_release_regions(pci);
> pci_disable_device(pci);
> @@ -302,6 +344,9 @@ static struct pci_driver acp3x_driver = {
> .id_table = snd_acp3x_ids,
> .probe = snd_acp3x_probe,
> .remove = snd_acp3x_remove,
> + .driver = {
> + .pm = &acp3x_pm,
> + }
> };
>
> module_pci_driver(acp3x_driver);
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-11-06 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573137364-5592-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
2019-11-07 14:35 ` [alsa-devel] [RESEND PATCH v2 1/7] ASoC: amd: Create multiple I2S platform device endpoints Ravulapati Vishnu vardhan rao
2019-11-06 16:17 ` Mark Brown
2019-11-06 16:24 ` Pierre-Louis Bossart
2019-11-07 14:35 ` [alsa-devel] [RESEND PATCH v2 2/7] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-11-06 16:31 ` Pierre-Louis Bossart
2019-11-07 14:36 ` [alsa-devel] [PATCH v2 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-11-06 16:34 ` Pierre-Louis Bossart
2019-11-06 17:06 ` Mark Brown
2019-11-07 14:36 ` [alsa-devel] [RESEND PATCH v2 4/7] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-11-07 14:36 ` [alsa-devel] [RESEND PATCH v2 5/7] ASoC: amd: handle ACP3x i2s-sp watermark interrupt Ravulapati Vishnu vardhan rao
2019-11-07 14:36 ` [alsa-devel] [PATCH v2 6/7] ASoC: amd: ACP powergating to be done by controller Ravulapati Vishnu vardhan rao
2019-11-06 16:40 ` Pierre-Louis Bossart
2019-11-07 14:36 ` [alsa-devel] [RESEND PATCH v2 7/7] ASoC: amd: Added ACP3x system resume and runtime pm ops Ravulapati Vishnu vardhan rao
2019-11-06 16:43 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c30bea61-8db4-fb7a-bead-c665f88b3091@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Akshu.Agrawal@amd.com \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=djkurtz@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).