From: Dan Murphy <dmurphy@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
<linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>
Cc: Jonghwan Choi <charlie.jh@kakaocorp.com>,
Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 29/38] ASoC: tas2562: skip of_device_id table when !CONFIG_OF
Date: Fri, 20 Nov 2020 10:21:56 -0600 [thread overview]
Message-ID: <cacd0acf-708d-0b56-8229-b76690b2d289@ti.com> (raw)
In-Reply-To: <20201120161653.445521-29-krzk@kernel.org>
Hello
On 11/20/20 10:16 AM, Krzysztof Kozlowski wrote:
> The driver can match by multiple methods. Its of_device_id table is
> referenced via of_match_ptr() so it will be unused for !CONFIG_OF
> builds:
>
> sound/soc/codecs/tas2562.c:805:34: warning: ‘tas2562_of_match’ defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> sound/soc/codecs/tas2562.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
> index f1ff204e3ad0..19965fabe949 100644
> --- a/sound/soc/codecs/tas2562.c
> +++ b/sound/soc/codecs/tas2562.c
> @@ -802,6 +802,7 @@ static const struct i2c_device_id tas2562_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, tas2562_id);
>
> +#ifdef CONFIG_OF
Should we use #if IS_ENABLED(CONFIG_OF) ?
Dan
next prev parent reply other threads:[~2020-11-20 16:33 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 16:16 [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 02/38] ASoC: gtm601: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 03/38] ASoC: inno_rk3036: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 04/38] ASoC: rk3328: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 05/38] ASoC: tas571x: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 06/38] ASoC: kirkwood: armada-370-db: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 07/38] ASoC: meson: t9015: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 08/38] ASoC: qcom: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 09/38] ASoC: samsung: smdk_wm8994: " Krzysztof Kozlowski
2020-11-20 16:43 ` Sylwester Nawrocki
2020-11-20 16:16 ` [PATCH 10/38] ASoC: rockchip: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 11/38] ASoC: ti: davinci: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 12/38] ASoC: uniphier: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 13/38] ASoC: ak4118: skip of_device_id table when !CONFIG_OF Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 14/38] ASoC: alc5623: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 15/38] ASoC: alc5632: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 16/38] ASoC: da7218: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 17/38] ASoC: da7219: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 18/38] ASoC: da9055: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 19/38] ASoC: es8316: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 20/38] ASoC: max98090: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 21/38] ASoC: max98095: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 22/38] ASoC: max98371: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 23/38] ASoC: max9867: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 24/38] ASoC: max98925: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 25/38] ASoC: max98926: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 26/38] ASoC: pcm1789: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 27/38] ASoC: pcm179x: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 28/38] ASoC: rt5660: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 29/38] ASoC: tas2562: " Krzysztof Kozlowski
2020-11-20 16:21 ` Dan Murphy [this message]
2020-11-20 16:36 ` Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 30/38] ASoC: tlv320: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 31/38] ASoC: ts3a227e: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 32/38] ASoC: es7134: mark OF related data as maybe unused Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 33/38] ASoC: es7241: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 34/38] ASoC: samsung: i2s: " Krzysztof Kozlowski
2020-11-20 16:41 ` Sylwester Nawrocki
2020-11-20 16:16 ` [PATCH 35/38] ASoC: max98371: drop driver pm=NULL assignment Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 36/38] ASoC: max98925: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 37/38] ASoC: max98926: " Krzysztof Kozlowski
2020-11-20 16:16 ` [PATCH 38/38] ASoC: samsung: smdk_wm8994: remove redundant of_match_ptr() Krzysztof Kozlowski
2020-11-20 16:47 ` Sylwester Nawrocki
2020-11-20 16:56 ` [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table Mark Brown
2020-11-20 19:42 ` Krzysztof Kozlowski
2020-11-20 20:04 ` Mark Brown
2020-11-22 10:59 ` Krzysztof Kozlowski
2020-11-23 10:48 ` Andy Shevchenko
2020-11-23 12:37 ` Mark Brown
2020-11-23 12:41 ` Krzysztof Kozlowski
2020-11-23 13:42 ` Andy Shevchenko
2020-11-23 13:45 ` Andy Shevchenko
2020-11-23 13:50 ` Mark Brown
2020-11-23 14:58 ` Krzysztof Kozlowski
2020-11-23 16:43 ` Mark Brown
2020-11-23 16:45 ` Krzysztof Kozlowski
2020-11-23 13:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cacd0acf-708d-0b56-8229-b76690b2d289@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=charlie.jh@kakaocorp.com \
--cc=krzk@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).