From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Derek [方德義]" <derek.fang@realtek.com>,
"sathya.prakash.m.r@intel.com" <sathya.prakash.m.r@intel.com>,
"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [alsa-devel] [PATCH RESEND] ASoC: rt1011: set tx/rx slots from tx/rx_mask in TDM case
Date: Mon, 14 Oct 2019 01:46:01 +0000 [thread overview]
Message-ID: <e7795e6625b145ecb7f8baf446e61dae@realtek.com> (raw)
In-Reply-To: <20191009141522.GD3929@sirena.co.uk>
> On Tue, Oct 08, 2019 at 09:32:05AM +0000, Shuming [范書銘] wrote:
>
> > + if (first_bit == 0 || first_bit == 2 ||
> > + first_bit == 4 || first_bit == 6) {
>
>
> > + } else {
> > + }
>
> This would be more idiomatically written as a switch statement, as would the
> equivalent stuff on the TX side.
OK, I will modify it as a switch statement and send v2 patch.
> ------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-10-14 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:32 [alsa-devel] [PATCH RESEND] ASoC: rt1011: set tx/rx slots from tx/rx_mask in TDM case Shuming [范書銘]
2019-10-09 14:15 ` Mark Brown
2019-10-14 1:46 ` Shuming [范書銘] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7795e6625b145ecb7f8baf446e61dae@realtek.com \
--to=shumingf@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=sathya.prakash.m.r@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).