From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<alsa-devel@alsa-project.org>
Cc: tiwai@suse.de, open list <linux-kernel@vger.kernel.org>,
Samuel Ortiz <samuel.ortiz@nokia.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
broonie@kernel.org, linux-omap@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'
Date: Wed, 8 Jul 2020 08:39:49 +0300 [thread overview]
Message-ID: <f386522e-04b3-21e8-bf9b-c5431622693f@ti.com> (raw)
In-Reply-To: <20200707190612.97799-10-pierre-louis.bossart@linux.intel.com>
On 07/07/2020 22.06, Pierre-Louis Bossart wrote:
> From: Lee Jones <lee.jones@linaro.org>
>
> Looks like 'w' has remained unchecked since the driver's inception.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
> sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]
>
> Peter suggested that the whole read can be removed, so that's
> been done too.
Thank you,
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/ti/omap-mcbsp-st.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
> index 5a32b54bbf3b..0bc7d26c660a 100644
> --- a/sound/soc/ti/omap-mcbsp-st.c
> +++ b/sound/soc/ti/omap-mcbsp-st.c
> @@ -142,11 +142,8 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
>
> static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
> {
> - u16 w;
> struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
>
> - w = MCBSP_ST_READ(mcbsp, SSELCR);
> -
> MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
> ST_CH1GAIN(st_data->ch1gain));
> }
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-07-08 5:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 19:05 [PATCH v3 00/13] ASoC: Clean-up W=1 build warnings - part1 Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 01/13] ASoC: atmel: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 02/13] ASoC: samsung: spdif: " Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 03/13] ASoC: samsung: pcm: " Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 04/13] ASoC: tegra: tegra20_das: remove always-true comparison Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 05/13] ASoC: uniphier: aio-core: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 06/13] ASoC: codecs: da7210: " Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 07/13] ASoC: codecs: da7219: fix 'defined but not used' warning Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 08/13] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv' Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Pierre-Louis Bossart
2020-07-08 5:39 ` Peter Ujfalusi [this message]
2020-07-07 19:06 ` [PATCH v3 10/13] ASoC: codecs: cros_ec_codec: fix 'defined but not used' warning Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 11/13] ASoC: codecs: es8316: " Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 12/13] ASoC: codecs: max98390: " Pierre-Louis Bossart
2020-07-07 19:06 ` [PATCH v3 13/13] ASoC: codecs: rt*: " Pierre-Louis Bossart
2020-07-09 22:00 ` [PATCH v3 00/13] ASoC: Clean-up W=1 build warnings - part1 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f386522e-04b3-21e8-bf9b-c5431622693f@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=samuel.ortiz@nokia.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).