From: Takashi Iwai <tiwai@suse.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
krzysztof.hejmowski@intel.com, filip.kaczmarski@intel.com,
harshapriya.n@intel.com, lgirdwood@gmail.com,
ppapierkowski@habana.ai, marcin.barlik@intel.com,
zwisler@google.com, alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, filip.proborszcz@intel.com,
broonie@kernel.org, amadeuszx.slawinski@linux.intel.com,
michal.wasko@intel.com, tiwai@suse.com,
andriy.shevchenko@linux.intel.com, cujomalainey@chromium.org,
vamshi.krishna.gopal@intel.com
Subject: Re: [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components
Date: Mon, 12 Oct 2020 11:09:04 +0200 [thread overview]
Message-ID: <s5ha6wrretr.wl-tiwai@suse.de> (raw)
In-Reply-To: <cf1fb47d-412f-48fd-4501-e63f1db32bc1@redhat.com>
On Mon, 12 Oct 2020 10:26:17 +0200,
Hans de Goede wrote:
>
> FWIW (since that this is already merged) I'm fine with removing the
> quite old Bay Trail support from common/sst-acpi.c, at least Fedora
> has been using the medium-old (with SOF being the new thing)
> CONFIG_SND_SST_IPC_ACPI support for Bay Trail audio support for
> quite some time now.
The same for openSUSE. Since CONFIG_SND_SOC_INTEL_BAYTRAIL is
exclusive against SOF and other modern codes, I guess it's quite
unlikely that any recent distros enable it.
> This is not just about Bay Trail And Cherry Trail devices though,
> this series also makes changes impacting Haswell and Broadwell devices.
>
> The commit removing this support claims that at least for Haswell the
> new sound/soc/intel/catpt replaces it, but I do not see that code in
> 5.9, so that means that in one cycle we are both introducing the
> replacement and dropping the old code ? I'm not sure if that is such
> a great idea, what is the fallback plan if testing does find significant
> issues with the new catpt code ?
I find the action a bit too rushing, too. OTOH, the old code wasn't
well maintained, honestly speaking. So, from another perspective,
switching to a new code can be seen as a better chance to fix any
bugs.
Of course, we could keep two stuff parallel, but it's rather
confusing. And, the HSW/BDW devices that need SST are quite rare and
old, so the impact is limited, I guess.
In anyway, let's cross fingers, and feed back to Cezary ASAP when we
get a regression.
thanks,
Takashi
next prev parent reply other threads:[~2020-10-12 9:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 6:48 [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 01/13] ASoC: Intel: Remove haswell solution Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 02/13] ASoC: Intel: Remove max98090 support for baytrail solution Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 03/13] ASoC: Intel: Remove rt5640 " Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 04/13] ASoC: Intel: Remove " Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 05/13] ASoC: Intel: Remove SST ACPI component Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 06/13] ASoC: Intel: Remove SST firmware components Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 07/13] ASoC: Intel: Skylake: Unassign ram_read and read_write ops Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 08/13] ASoC: Intel: Remove unused DSP operations Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 09/13] ASoC: Intel: Remove unused DSP interface fields Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 10/13] ASoC: Intel: Remove SST-legacy specific constants Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 11/13] ASoC: Intel: Make atom components independent of sst-dsp Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 12/13] ASoC: Intel: Remove sst_pdata structure Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 13/13] ASoC: Intel: Remove sst_dsp_get_thread_context Cezary Rojewski
2020-10-06 12:22 ` [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components Liam Girdwood
2020-10-06 15:20 ` Pierre-Louis Bossart
2020-10-06 15:20 ` Mark Brown
2020-10-12 8:26 ` Hans de Goede
2020-10-12 9:09 ` Takashi Iwai [this message]
2020-10-12 11:36 ` Mark Brown
2020-10-12 11:53 ` Hans de Goede
2020-10-12 12:19 ` Rojewski, Cezary
2020-10-12 12:39 ` Mark Brown
2020-10-12 9:24 ` Rojewski, Cezary
2020-10-12 9:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha6wrretr.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=filip.kaczmarski@intel.com \
--cc=filip.proborszcz@intel.com \
--cc=harshapriya.n@intel.com \
--cc=hdegoede@redhat.com \
--cc=krzysztof.hejmowski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=marcin.barlik@intel.com \
--cc=michal.wasko@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ppapierkowski@habana.ai \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).