alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
	linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
	tiwai@suse.com, vkoul@kernel.org, broonie@kernel.org
Subject: Re: [RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback
Date: Thu, 23 Jul 2020 14:38:09 +0200	[thread overview]
Message-ID: <s5hpn8mqudq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200721170007.4554-1-srinivas.kandagatla@linaro.org>

On Tue, 21 Jul 2020 19:00:01 +0200,
Srinivas Kandagatla wrote:
> 
> For gapless playback it is possible that each track can have different
> codec profile with same decoder, for example we have WMA album,
> we may have different tracks as WMA v9, WMA v10 and so on
> Or if DSP's like QDSP have abililty to switch decoders on single stream
> for each track, then this call could be used to set new codec parameters.
> 
> Existing code does not allow to change this profile while doing gapless
> playback.
> 
> This patchset adds new SNDRV_COMPRESS_SET_CODEC_PARAMS IOCTL along with
> flags in capablity structure to allow userspace to set this new
> parameters required which switching codec profile, either for gapless
> or cross fade usecase.

One idea that came up at the previous audio conference regarding this
implementation was to just allow SET_PARAMS during the stream is
running (only if the driver sets the capability) instead of
introducing yet a new ioctl and an ops.
Would it make sense?

I have no big objection to add a new ioctl if other people agree,
though.


thanks,

Takashi

  parent reply	other threads:[~2020-07-23 12:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 17:00 [RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 1/6] ALSA: compress: move codec parameter check to a function Srinivas Kandagatla
2020-07-21 19:56   ` Pierre-Louis Bossart
2020-07-21 17:00 ` [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters Srinivas Kandagatla
2020-07-21 20:05   ` Pierre-Louis Bossart
2020-07-22  8:59     ` Srinivas Kandagatla
2020-07-22 15:36       ` Pierre-Louis Bossart
2020-07-23  4:47         ` Vinod Koul
2020-07-23 13:17           ` Pierre-Louis Bossart
2020-07-21 17:00 ` [RFC PATCH v2 3/6] ALSA: compress: add flags to snd_compr_caps to expose dsp caps Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 4/6] ASoC: compress: add snd_soc_dai_compr_set_codec_params() Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 5/6] ALSA: compress: bump the version Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 6/6] ASoC: q6asm-dai: add support to set_codec_params Srinivas Kandagatla
2020-07-21 20:09   ` Pierre-Louis Bossart
2020-07-22  8:59     ` Srinivas Kandagatla
2020-07-22 14:04   ` Daniel Baluta
2020-07-23 12:38 ` Takashi Iwai [this message]
2020-07-23 13:05   ` [RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback Vinod Koul
2020-07-23 13:17     ` Takashi Iwai
2020-07-23 15:56       ` Vinod Koul
2020-07-23 20:33         ` Takashi Iwai
2020-08-06 11:08           ` Vinod Koul
2020-08-06 16:28             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpn8mqudq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).