From: Takashi Iwai <tiwai@suse.de>
To: Sami Loone <sami@loone.fi>
Cc: Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ALSA: hda/realtek: ALC285 Thinkpad jack pin quirk is unreachable
Date: Mon, 03 May 2021 10:40:55 +0200 [thread overview]
Message-ID: <s5hsg34ryzs.wl-tiwai@suse.de> (raw)
In-Reply-To: <YI0oefvTYn8URYDb@yoga>
On Sat, 01 May 2021 12:07:53 +0200,
Sami Loone wrote:
>
> In 07d9e69cf34a ("ALSA: hda/realtek: fix static noise on ALC285 Lenovo
> laptops") an existing Lenovo quirk was made more generic by removing a
> 0x12 pin requirement from the entry. This made the second chance table
> Thinkpad jack entry unreachable as the pin configurations became
> identical.
>
> Revert the 0x12 pin requirement removal and move Thinkpad jack pin quirk
> back to the primary pin table as they can co-exist when more specific
> configurations come first.
>
> Add a more targeted pin quirk for Lenovo devices that have 0x12 as
> 0x40000000.
>
> Tested on Yoga 6 (AMD) laptop.
>
> Fixes: 07d9e69cf34a ("ALSA: hda/realtek: fix static noise on ALC285 Lenovo laptops")
> Signed-off-by: Sami Loone <sami@loone.fi>
Applied now.
The commit ID doesn't exist in the upstream, so I corrected it.
thanks,
Takashi
prev parent reply other threads:[~2021-05-03 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 10:07 [PATCH] ALSA: hda/realtek: ALC285 Thinkpad jack pin quirk is unreachable Sami Loone
2021-05-03 8:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsg34ryzs.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=sami@loone.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).