alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: "František Kučera" <konference@frantovo.cz>,
	alsa-devel@alsa-project.org, Geraldo <geraldogabriel@gmail.com>
Subject: Re: [PATCH v5 3/5] ALSA: usb-audio: Avoid unnecessary interface re-setup
Date: Fri, 05 Feb 2021 09:09:10 +0100	[thread overview]
Message-ID: <s5hwnvn3pi1.wl-tiwai@suse.de> (raw)
In-Reply-To: <87fd2b96-1e4f-aa1a-3048-9c57351519b6@linux.intel.com>

On Thu, 04 Feb 2021 22:44:00 +0100,
Pierre-Louis Bossart wrote:
> 
> 
> 
> >   /**
> > - * snd_usb_endpoint_free: Free the resources of an snd_usb_endpoint
> > + * snd_usb_endpoint_free_all: Free the resources of an snd_usb_endpoint
> > + * @card: The chip
> >    *
> > - * @ep: the endpoint to free
> > - *
> > - * This free all resources of the given ep.
> > + * This free all endpoints and those resources
> >    */
> > -void snd_usb_endpoint_free(struct snd_usb_endpoint *ep)
> > +void snd_usb_endpoint_free_all(struct snd_usb_audio *chip)
> 
> this causes warnings with make sound/ W=1
> 
>   CC [M]  sound/usb/endpoint.o
> sound/usb/endpoint.c:1459: warning: Function parameter or member
> 'chip' not described in 'snd_usb_endpoint_free_all'
> sound/usb/endpoint.c:1459: warning: Excess function parameter 'card'
> description in 'snd_usb_endpoint_free_all'
> 
> the following diff removes it, but I don't know if the description is
> good enough...
> 
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index 8e568823c992..4d1c678a0d80 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -1451,7 +1451,7 @@ void snd_usb_endpoint_release(struct
> snd_usb_endpoint *ep)
> 
>  /**
>   * snd_usb_endpoint_free_all: Free the resources of an snd_usb_endpoint
> - * @card: The chip
> + * @chip: The chip
>   *
>   * This free all endpoints and those resources
>   */

Thanks, I'll queue the fix.


Takashi

  reply	other threads:[~2021-02-05  8:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  7:52 [PATCH v5 0/5] ALSA: usb-audio: Fixes for Pioneer devices Takashi Iwai
2021-01-08  7:52 ` [PATCH v5 1/5] ALSA: usb-audio: Fix the missing endpoints creations for quirks Takashi Iwai
2021-01-08  7:52 ` [PATCH v5 2/5] ALSA: usb-audio: Choose audioformat of a counter-part substream Takashi Iwai
2021-01-08  7:52 ` [PATCH v5 3/5] ALSA: usb-audio: Avoid unnecessary interface re-setup Takashi Iwai
2021-02-04 21:44   ` Pierre-Louis Bossart
2021-02-05  8:09     ` Takashi Iwai [this message]
2021-01-08  7:52 ` [PATCH v5 4/5] ALSA: usb-audio: Annotate the endpoint index in audioformat Takashi Iwai
2021-01-08  7:52 ` [PATCH v5 5/5] ALSA: usb-audio: Fix implicit feedback sync setup for Pioneer devices Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwnvn3pi1.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=geraldogabriel@gmail.com \
    --cc=konference@frantovo.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).