From: "Christian König" <christian.koenig@amd.com>
To: Luben Tuikov <luben.tuikov@amd.com>,
xinhui pan <xinhui.pan@amd.com>,
amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, Guchun.Chen@amd.com
Subject: Re: [PATCH] drm/amdgpu: Fix size calculation when init onchip memory
Date: Mon, 26 Oct 2020 08:49:45 +0100 [thread overview]
Message-ID: <1de6eb8d-3432-6d25-feba-e646f92596b6@amd.com> (raw)
In-Reply-To: <7ebfd8ba-9d8a-0874-2fde-271f751067c2@amd.com>
Am 24.10.20 um 01:19 schrieb Luben Tuikov:
> On 2020-10-23 03:12, Christian König wrote:
>> Am 23.10.20 um 07:41 schrieb xinhui pan:
>>> Size is page count here.
>>>
>>> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
>> Ah yes that one again. At some point we really need to clean that up.
>>
>> Patch is Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>>> index 4a85f8cedd77..11dd3d9eac15 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>>> @@ -65,11 +65,11 @@
>>>
>>> static int amdgpu_ttm_init_on_chip(struct amdgpu_device *adev,
>>> unsigned int type,
>>> - uint64_t size)
>>> + uint64_t size_in_page)
>>> {
>>> return ttm_range_man_init(&adev->mman.bdev, type,
>>> TTM_PL_FLAG_UNCACHED, TTM_PL_FLAG_UNCACHED,
>>> - false, size >> PAGE_SHIFT);
>>> + false, size_in_page);
> Why don't we call this "page_count" or "num_pages"?
> "size_in_page" is really confusing and not something people
> say and use in English.
Thinking more about it it would even better if we just stick with size,
cause this is a size in arbitrary units (and NOT pages!).
It's just TTM which misinterprets that as number of pages which is
something Dave and I are trying to fix right now.
Regards,
Christian.
>
> Regards,
> Luben
>
>>> }
>>>
>>> /**
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cluben.tuikov%40amd.com%7C868c9232cb924441c02308d8772307e4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637390339646490801%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=H5r9C%2Bj3zVEsGSDNUlxl1%2Bg7lytcsczO7KpSymIv%2F0E%3D&reserved=0
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-10-26 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 5:41 [PATCH] drm/amdgpu: Fix size calculation when init onchip memory xinhui pan
2020-10-23 7:12 ` Christian König
2020-10-23 23:19 ` Luben Tuikov
2020-10-26 7:49 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de6eb8d-3432-6d25-feba-e646f92596b6@amd.com \
--to=christian.koenig@amd.com \
--cc=Guchun.Chen@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=luben.tuikov@amd.com \
--cc=xinhui.pan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).