From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: Charlene Liu <Charlene.Liu@amd.com>,
Chris Park <Chris.Park@amd.com>,
Sunpeng.Li@amd.com, Harry.Wentland@amd.com,
qingqing.zhuo@amd.com, Rodrigo.Siqueira@amd.com,
Aurabindo.Pillai@amd.com, Bhawanpreet.Lakha@amd.com
Subject: [PATCH 18/30] drm/amd/display: Force ODM combine on 5K+ 420 modes
Date: Fri, 19 Jun 2020 16:12:10 -0400 [thread overview]
Message-ID: <20200619201222.2916504-19-Rodrigo.Siqueira@amd.com> (raw)
In-Reply-To: <20200619201222.2916504-1-Rodrigo.Siqueira@amd.com>
From: Chris Park <Chris.Park@amd.com>
[Why]
All YCbCr420 resolutions 5K and above have tiling and discoloration
issues. The issue can be remedied by forcing ODM combine from 5K to 8K.
10K resolution requires ODM 4:1. The mechanism of what the real problem
is, that is inherent in ODM combine programming, doesn't seem to be
pointed at singular register programming (CLK, MPC, DCSURF, etc.), and
needs more in-depth programming sequence review for these new use case
scenarios. Until then, workaround to enable ODM combine is proposed.
While it is not our policy, HW spreadsheet also recommends turning on
ODM for these scenario to lower the voltage.
[How]
Make pixel encoding and resolution size specific workaround to enable
ODM combine on YCbCr420 high resolution modes.
Signed-off-by: Chris Park <Chris.Park@amd.com>
Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
---
.../drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
index 2a32ed6682fc..5909af0a25fb 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
@@ -3986,9 +3986,19 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
} else if (v->PlaneRequiredDISPCLKWithoutODMCombine > v->MaxDispclkRoundedDownToDFSGranularity) {
v->ODMCombineEnablePerState[i][k] = dm_odm_combine_mode_2to1;
v->PlaneRequiredDISPCLK = v->PlaneRequiredDISPCLKWithODMCombine2To1;
+ /*420 format workaround*/
+ if (v->HActive[k] > 7680 && v->OutputFormat[k] == dm_420) {
+ v->ODMCombineEnablePerState[i][k] = dm_odm_combine_mode_2to1;
+ v->PlaneRequiredDISPCLK = v->PlaneRequiredDISPCLKWithODMCombine2To1;
+ }
} else {
v->ODMCombineEnablePerState[i][k] = dm_odm_combine_mode_disabled;
v->PlaneRequiredDISPCLK = v->PlaneRequiredDISPCLKWithoutODMCombine;
+ /*420 format workaround*/
+ if (v->HActive[k] > 4096 && v->OutputFormat[k] == dm_420) {
+ v->ODMCombineEnablePerState[i][k] = dm_odm_combine_mode_2to1;
+ v->PlaneRequiredDISPCLK = v->PlaneRequiredDISPCLKWithODMCombine2To1;
+ }
}
if (v->ODMCombineEnablePerState[i][k] == dm_odm_combine_mode_4to1) {
--
2.27.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-06-19 20:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 20:11 [PATCH 00/30] DC Patches Jun 19, 2020 Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 01/30] drm/amd/display: Use dmub fw to lock pipe, cursor, dig Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 02/30] drm/amd/display: [FW Promotion] Release 1.0.16 Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 03/30] drm/amd/display: Fix calculation of virtual channel payload Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 04/30] drm/amd/display: Fixed using wrong eDP power sequence function pointer Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 05/30] drm/amd/display: [FW Promotion] Release 1.0.17 Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 06/30] drm/amd/display: implement edid max TMDS clock check in DC Rodrigo Siqueira
2020-06-19 20:11 ` [PATCH 07/30] drm/amd/display: enable assr Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 08/30] drm/amd/display: Fix DML failures caused by doubled stereo viewport Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 09/30] drm/amd/display: Correctly respond in psr enablement interface Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 10/30] drm/amd/display: [FW Promotion] Release 1.0.18 Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 11/30] drm/amd/display: 3.2.90 Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 12/30] drm/amd/display: clip plane rects in DM before passing into DC Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 13/30] drm/amd/display: Added local_sink null check before access Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 14/30] drm/amd/display: fine tune logic of edid max TMDS clock check Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 15/30] drm/amd/display: add mechanism to skip DCN init Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 16/30] drm/amd/display: use dispclk AVFS for dppclk Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 17/30] drm/amd/display: fix 4to1 odm MPC_OUT_FLOW_CONTROL_COUNT Rodrigo Siqueira
2020-06-19 20:12 ` Rodrigo Siqueira [this message]
2020-06-19 20:12 ` [PATCH 19/30] drm/amd/display: Enable output_bpc property on all outputs Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 20/30] drm/amd/display: Fill in dmub_srv fw_version from firmware metadata Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 21/30] drm/amd/display: VSC SDP supported for SST Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 22/30] drm/amd/display: Allow 4 split on 10K 420 modes Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 23/30] drm/amd/display: Red screen observed on startup Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 24/30] drm/amd/display: enable seamless boot for dcn30 Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 25/30] drm/amd/display: Compare v_front_porch when checking if streams are synchronizable Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 26/30] drm/amd/display: allow query ddc data over aux to be read only operation Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 27/30] drm/amd/display: DP link layer test 4.2.1.1 fix due to specs update Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 28/30] drm/amd/display: [FW Promotion] Release 1.0.19 Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 29/30] drm/amd/display: Fix ineffective setting of max bpc property Rodrigo Siqueira
2020-06-19 20:12 ` [PATCH 30/30] drm/amd/display: 3.2.91 Rodrigo Siqueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619201222.2916504-19-Rodrigo.Siqueira@amd.com \
--to=rodrigo.siqueira@amd.com \
--cc=Aurabindo.Pillai@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Charlene.Liu@amd.com \
--cc=Chris.Park@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=qingqing.zhuo@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).