amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Philip Yang <Philip.Yang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Felix.Kuehling@amd.com>, <christian.koenig@amd.com>,
	<Arunpravin.PaneerSelvam@amd.com>,
	Philip Yang <Philip.Yang@amd.com>
Subject: [PATCH v2 3/6] drm/amdkfd: Evict BO itself for contiguous allocation
Date: Thu, 18 Apr 2024 09:58:00 -0400	[thread overview]
Message-ID: <20240418135803.17365-4-Philip.Yang@amd.com> (raw)
In-Reply-To: <20240418135803.17365-1-Philip.Yang@amd.com>

If the BO pages pinned for RDMA is not contiguous on VRAM, evict it to
system memory first to free the VRAM space, then allocate contiguous
VRAM space, and then move it from system memory back to VRAM.

Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
 .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c    | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index ef9154043757..ff7f54741661 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1470,13 +1470,28 @@ static int amdgpu_amdkfd_gpuvm_pin_bo(struct amdgpu_bo *bo, u32 domain)
 	if (unlikely(ret))
 		return ret;
 
+	if (bo->flags & AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS) {
+		/*
+		 * If bo is not contiguous on VRAM, move to system memory first to ensure
+		 * we can get contiguous VRAM space after evicting other BOs.
+		 */
+		if (!(bo->tbo.resource->placement & TTM_PL_FLAG_CONTIGUOUS)) {
+			ret = amdgpu_amdkfd_bo_validate(bo, AMDGPU_GEM_DOMAIN_GTT, false);
+			if (unlikely(ret)) {
+				pr_debug("validate bo 0x%p to GTT failed %d\n", &bo->tbo, ret);
+				goto out;
+			}
+		}
+	}
+
 	ret = amdgpu_bo_pin_restricted(bo, domain, 0, 0);
 	if (ret)
 		pr_err("Error in Pinning BO to domain: %d\n", domain);
 
 	amdgpu_bo_sync_wait(bo, AMDGPU_FENCE_OWNER_KFD, false);
-	amdgpu_bo_unreserve(bo);
 
+out:
+	amdgpu_bo_unreserve(bo);
 	return ret;
 }
 
-- 
2.43.2


  parent reply	other threads:[~2024-04-18 13:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 13:57 [PATCH v2 0/6] Best effort contiguous VRAM allocation Philip Yang
2024-04-18 13:57 ` [PATCH v2 1/6] drm/amdgpu: Support " Philip Yang
2024-04-18 14:37   ` Christian König
2024-04-18 20:50     ` Philip Yang
2024-04-18 13:57 ` [PATCH v2 2/6] drm/amdgpu: Evict BOs from same process for contiguous allocation Philip Yang
2024-04-18 13:58 ` Philip Yang [this message]
2024-04-18 13:58 ` [PATCH v2 4/6] drm/amdkfd: Increase KFD bo restore wait time Philip Yang
2024-04-18 13:58 ` [PATCH v2 5/6] drm/amdgpu: Skip dma map resource for null RDMA device Philip Yang
2024-04-18 13:58 ` [PATCH v2 6/6] drm/amdkfd: Bump kfd version for contiguous VRAM allocation Philip Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418135803.17365-4-Philip.Yang@amd.com \
    --to=philip.yang@amd.com \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).