Re: [PATCH v1 11/12] fbdev/smscufx: Make I2C terminology more inclusive

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
	Steve Glendinning <steve.glendinning@shawell.net>,
	Helge Deller <deller@gmx.de>,
	"open list:SMSC UFX6000 and UFX7000 USB to VGA DRIVER"
	<linux-fbdev@vger.kernel.org>,
	"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
	open list <linux-kernel@vger.kernel.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
	<intel-gfx@lists.freedesktop.org>,
	"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
	<intel-xe@lists.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	"open list:I2C SUBSYSTEM HOST DRIVERS"
	<linux-i2c@vger.kernel.org>,
	"open list:BTTV VIDEO4LINUX DRIVER" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v1 11/12] fbdev/smscufx: Make I2C terminology more inclusive
Date: Thu, 2 May 2024 12:45:51 +0200	[thread overview]
Message-ID: <80dce2c9-6b02-481e-bac8-e0d2e339727c@suse.de> (raw)
In-Reply-To: <20240430173812.1423757-12-eahariha@linux.microsoft.com>


Am 30.04.24 um 19:38 schrieb Easwar Hariharan:
> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.
>
> Compile tested, no functionality changes intended
>
> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
>
> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/smscufx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
> index 35d682b110c4..1c80c1a3d516 100644
> --- a/drivers/video/fbdev/smscufx.c
> +++ b/drivers/video/fbdev/smscufx.c
> @@ -1292,7 +1292,7 @@ static int ufx_realloc_framebuffer(struct ufx_data *dev, struct fb_info *info)
>   	return 0;
>   }
>   
> -/* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, master,
> +/* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, host,
>    * restart enabled, but no start byte, enable controller */
>   static int ufx_i2c_init(struct ufx_data *dev)
>   {
> @@ -1321,7 +1321,7 @@ static int ufx_i2c_init(struct ufx_data *dev)
>   	/* 7-bit (not 10-bit) addressing */
>   	tmp &= ~(0x10);
>   
> -	/* enable restart conditions and master mode */
> +	/* enable restart conditions and host mode */
>   	tmp |= 0x21;
>   
>   	status = ufx_reg_write(dev, 0x1000, tmp);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)