From: Alex Deucher <alexdeucher@gmail.com>
To: Daniel Drake <drake@endlessm.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
Chunming Zhou <David1.Zhou@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: always reset asic when going into suspend
Date: Thu, 19 Dec 2019 09:08:44 -0500 [thread overview]
Message-ID: <CADnq5_OObnKTP7-tBmPz75R5qXs8ubRxgfX-qkBnzqcox0TZyQ@mail.gmail.com> (raw)
In-Reply-To: <CAD8Lp46+Te+AUQKLkLEcGf34izw=JzkU5w=CsZRf_UKJQ_k7qg@mail.gmail.com>
On Mon, Dec 16, 2019 at 4:00 AM Daniel Drake <drake@endlessm.com> wrote:
>
> Hi Alex,
>
> On Mon, Nov 25, 2019 at 1:17 PM Daniel Drake <drake@endlessm.com> wrote:
> > Unfortunately not. The original issue still exists (dead gfx after
> > resume from s2idle) and also when I trigger execution of the suspend
> > or runtime suspend routines the power usage increases around 1.5W as
> > before.
> >
> > Have you confirmed that amdgpu s2idle is working on platforms you have in hand?
>
> Any further ideas here? Or any workarounds that you would consider?
I think there may be some AMD specific handling needed in
drivers/acpi/sleep.c. My understanding from reading the modern
standby documents from MS is that each vendor needs to provide a
platform specific PEP driver. I'm not sure how much of that current
code is Intel specific or not.
Alex
>
> This platform has been rather tricky but all of the other problems are
> now solved:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f897e60a12f0b9146357780d317879bce2a877dc
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d21b8adbd475dba19ac2086d3306327b4a297418
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=406857f773b082bc88edfd24967facf4ed07ac85
> https://patchwork.kernel.org/patch/11263477/
>
> amdgpu is the only breakage left before Linux can be shipped on this
> family of products.
>
> Thanks
> Daniel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-12-19 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 6:50 [PATCH] drm/amdgpu: always reset asic when going into suspend Daniel Drake
[not found] ` <20191015065002.18701-1-drake-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
2019-10-15 18:42 ` Alex Deucher
[not found] ` <CADnq5_M4Leu0raYS6M72MqTm1+PLg9BjHCHLAYuB2-dEVP56_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-10-16 7:23 ` Daniel Drake
[not found] ` <CAD8Lp443ZhPEo0PJRxbTSB9DY9x92OvWBeH29m9Ehpyhg+2n5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-22 15:31 ` Alex Deucher
2019-11-22 15:31 ` Alex Deucher
[not found] ` <CADnq5_OaATVESAY9E2mtd7PoV2VjG=WLS56LCHVpieSHDTas0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-25 5:17 ` Daniel Drake
2019-11-25 5:17 ` Daniel Drake
2019-12-16 9:00 ` Daniel Drake
2019-12-19 14:08 ` Alex Deucher [this message]
2020-01-15 7:44 ` Daniel Drake
2020-01-16 15:14 ` Alex Deucher
2020-02-07 4:52 ` Daniel Drake
2020-10-23 15:04 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_OObnKTP7-tBmPz75R5qXs8ubRxgfX-qkBnzqcox0TZyQ@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=David1.Zhou@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=drake@endlessm.com \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).