From: Alex Deucher <alexdeucher@gmail.com>
To: amd-gfx list <amd-gfx@lists.freedesktop.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu/display: fix indentation in defer_delay_converter_wa()
Date: Tue, 27 Oct 2020 11:19:32 -0400 [thread overview]
Message-ID: <CADnq5_Panm5jhT+m5UJUjSC3P_joC6QoJ_K9jN+P6PqDpZKLyA@mail.gmail.com> (raw)
In-Reply-To: <20201026175045.1064936-1-alexander.deucher@amd.com>
Ping?
On Mon, Oct 26, 2020 at 1:50 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> Fixes this warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c: In function ‘defer_delay_converter_wa’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
> 285 | if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_0080E1 &&
> | ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:291:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
> 291 | if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
> | ^~
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> index ef0f50db4907..54beda4d4e85 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> @@ -283,15 +283,15 @@ static uint32_t defer_delay_converter_wa(
> struct dc_link *link = ddc->link;
>
> if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_0080E1 &&
> - !memcmp(link->dpcd_caps.branch_dev_name,
> - DP_DVI_CONVERTER_ID_4,
> - sizeof(link->dpcd_caps.branch_dev_name)))
> + !memcmp(link->dpcd_caps.branch_dev_name,
> + DP_DVI_CONVERTER_ID_4,
> + sizeof(link->dpcd_caps.branch_dev_name)))
> return defer_delay > I2C_OVER_AUX_DEFER_WA_DELAY ?
> defer_delay : I2C_OVER_AUX_DEFER_WA_DELAY;
> - if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
> - !memcmp(link->dpcd_caps.branch_dev_name,
> - DP_DVI_CONVERTER_ID_5,
> - sizeof(link->dpcd_caps.branch_dev_name)))
> + if (link->dpcd_caps.branch_dev_id == DP_BRANCH_DEVICE_ID_006037 &&
> + !memcmp(link->dpcd_caps.branch_dev_name,
> + DP_DVI_CONVERTER_ID_5,
> + sizeof(link->dpcd_caps.branch_dev_name)))
> return defer_delay > I2C_OVER_AUX_DEFER_WA_DELAY_1MS ?
> I2C_OVER_AUX_DEFER_WA_DELAY_1MS : defer_delay;
>
> --
> 2.25.4
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-10-27 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 17:50 [PATCH] drm/amdgpu/display: fix indentation in defer_delay_converter_wa() Alex Deucher
2020-10-27 15:19 ` Alex Deucher [this message]
2020-10-28 1:57 ` Quan, Evan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Panm5jhT+m5UJUjSC3P_joC6QoJ_K9jN+P6PqDpZKLyA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).