amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Lang Yu <Lang.Yu@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Veerabadhran Gopalakrishnan <Veerabadhran.Gopalakrishnan@amd.com>
Subject: Re: [PATCH] drm/amdgpu/umsch: don't execute umsch test when GPU is in reset/suspend
Date: Fri, 19 Apr 2024 11:50:25 +0200	[thread overview]
Message-ID: <b7007a8f-a39b-47ed-a858-48a7bbf6db83@gmail.com> (raw)
In-Reply-To: <20240419075203.37194-1-Lang.Yu@amd.com>

Am 19.04.24 um 09:52 schrieb Lang Yu:
> umsch test needs full GPU functionality(e.g., VM update, TLB flush,
> possibly buffer moving under memory pressure) which may be not ready
> under these states. Just skip it to avoid potential issues.
>
> Signed-off-by: Lang Yu <Lang.Yu@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c
> index 06ad68714172..9f9d6a6d5cf3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c
> @@ -774,6 +774,9 @@ static int umsch_mm_late_init(void *handle)
>   {
>   	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>   
> +	if (amdgpu_in_reset(adev) || adev->in_s0ix || adev->in_suspend)
> +		return 0;
> +
>   	return umsch_mm_test(adev);
>   }
>   


      parent reply	other threads:[~2024-04-19  9:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19  7:52 [PATCH] drm/amdgpu/umsch: don't execute umsch test when GPU is in reset/suspend Lang Yu
2024-04-19  8:43 ` Gopalakrishnan, Veerabadhran (Veera)
2024-04-19  9:50 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7007a8f-a39b-47ed-a858-48a7bbf6db83@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=Lang.Yu@amd.com \
    --cc=Veerabadhran.Gopalakrishnan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).