Re: [PATCH v4 3/3] ath10k: allow dynamic SAR power limits via common API

From: kernel test robot <lkp@intel.com>
To: Carl Huang <cjhuang@codeaurora.org>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, briannorris@chromium.org,
	kbuild-all@lists.01.org, dianders@chromium.org
Subject: Re: [PATCH v4 3/3] ath10k: allow dynamic SAR power limits via common API
Date: Thu, 3 Dec 2020 23:09:26 +0800	[thread overview]
Message-ID: <202012032348.xLCFrfwk-lkp@intel.com> (raw)
In-Reply-To: <20201203103728.3034-4-cjhuang@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2302 bytes --]

Hi Carl,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on next-20201203]
[cannot apply to mac80211/master ath6kl/ath-next v5.10-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Carl-Huang/add-common-API-to-configure-SAR/20201203-185909
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: h8300-randconfig-r034-20201203 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4853340d7334f175d6980db94a6f57c256d749d9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Carl-Huang/add-common-API-to-configure-SAR/20201203-185909
        git checkout 4853340d7334f175d6980db94a6f57c256d749d9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/ath10k/mac.c:84:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
      84 | const static struct cfg80211_sar_freq_ranges ath10k_sar_freq_ranges[] = {
         | ^~~~~
   drivers/net/wireless/ath/ath10k/mac.c:89:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
      89 | const static struct cfg80211_sar_capa ath10k_sar_capa = {
         | ^~~~~

vim +/static +84 drivers/net/wireless/ath/ath10k/mac.c

    83	
  > 84	const static struct cfg80211_sar_freq_ranges ath10k_sar_freq_ranges[] = {
    85		{.start_freq = 2402, .end_freq = 2494 },
    86		{.start_freq = 5170, .end_freq = 5875 },
    87	};
    88	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39327 bytes --]

[-- Attachment #3: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k