ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
	mingo@redhat.com, kuba@kernel.org, will@kernel.org,
	davem@davemloft.net, kvalo@codeaurora.org
Subject: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()
Date: Fri, 26 Feb 2021 22:07:04 +0100	[thread overview]
Message-ID: <YDli+H48Ft3F6k9/@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <a40d18bba5a52662ac8fc556e1fce3752ea08472.1614355914.git.skhan@linuxfoundation.org>

On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote:
> +		/* avoid false negative lockdep_assert_not_held()
> +		 * and lockdep_assert_held()
> +		 */

That's a coding style fail.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2021-02-26 21:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 17:52 [PATCH v2 0/3] Add lockdep_assert_not_held() Shuah Khan
2021-02-26 17:52 ` [PATCH v2 1/3] lockdep: add lockdep_assert_not_held() Shuah Khan
2021-02-26 21:07   ` Peter Zijlstra [this message]
2021-02-26 21:16     ` Shuah Khan
2021-03-01  8:28       ` Peter Zijlstra
2021-02-26 17:52 ` [PATCH v2 2/3] lockdep: add lockdep lock state defines Shuah Khan
2021-02-26 18:03   ` Johannes Berg
2021-02-26 18:16     ` Shuah Khan
2021-02-26 17:52 ` [PATCH v2 3/3] ath10k: detect conf_mutex held ath10k_drain_tx() calls Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDli+H48Ft3F6k9/@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).