From: wi nk <wink@technolu.st>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Stephen Liang <stephenliang7@gmail.com>,
Carl Huang <cjhuang@codeaurora.org>,
"ath11k@lists.infradead.org" <ath11k@lists.infradead.org>,
Mitchell Nordine <mail@mitchellnordine.com>
Subject: Re: ath11k: QCA6390 on Dell XPS 13 and kernel crashes
Date: Sat, 12 Dec 2020 12:46:07 +0100 [thread overview]
Message-ID: <CAHUdJJUQmRkh2vAFksvnSqwN5hk58O8Smrf_-PSfwaJwC+D2CQ@mail.gmail.com> (raw)
In-Reply-To: <874kkr4mba.fsf@codeaurora.org>
On Sat, Dec 12, 2020 at 6:37 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> wi nk <wink@technolu.st> writes:
>
> >> > and the modification that disables m2 state:
> >> >
> >> > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> >> > index 3de7b1639ec6..20f670c8b129 100644
> >> > --- a/drivers/bus/mhi/core/pm.c
> >> > +++ b/drivers/bus/mhi/core/pm.c
> >> > @@ -55,12 +55,12 @@ static struct mhi_pm_transitions const
> >> > dev_state_transitions[] = {
> >> > },
> >> > {
> >> > MHI_PM_M0,
> >> > - MHI_PM_M0 | MHI_PM_M2 | MHI_PM_M3_ENTER |
> >> > + MHI_PM_M0 | MHI_PM_M3_ENTER |
> >> > MHI_PM_SYS_ERR_DETECT | MHI_PM_SHUTDOWN_PROCESS |
> >> > MHI_PM_LD_ERR_FATAL_DETECT | MHI_PM_FW_DL_ERR
> >> > },
> >> > {
> >> > - MHI_PM_M2,
> >> > + MHI_PM_M0,
> >> > MHI_PM_M0 | MHI_PM_SYS_ERR_DETECT | MHI_PM_SHUTDOWN_PROCESS |
> >> > MHI_PM_LD_ERR_FATAL_DETECT
> >> > },
> >>
> >> Adding one more data point. The driver will not crash on
> >> initialization this way, but also with the M2 state transition
> >> disabled the system survives suspend and wake and the adapter
> >> successfully reassociates consistently. As expected with my patch,
> >> the MHI driver shows everything stays in the M1 state instead of
> >> attempting to transition to M2 ever. It also doesn't return back to
> >> M0 if I disconnect the power / replug it. I'm not sure what things
> >> are affected by me hacking this state machine, but avoiding that M2
> >> transition has removed any obvious issues from my system.
> >
> > While waiting for someone else to confirm, I can report that I've
> > still not seen any instability since this patch. The laptop has been
> > stable through reboots, power cycling, suspension, etc.
>
> Very interesting! Are you saying that with this patch the wireless
> connection using QCA6390 works fine on your Dell XPS 9310, you can
> connect to an AP and transfer data normally?
>
Precisely. The machine is now over 24h of uptime, I can reboot/sleep
without any issues, and throughput seems to saturate my wifi link
(5-600mpbs).
> I would like to submit your patch to patchwork.kernel.org as RFC patch
> so that it's easier for everyone to download. But before I can do that I
> need your Signed-off-by, can you read Developer's Certificate of Origin:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
> And if you agree with the DCO please send your s-o-b by replying to this
> email. But you can also submit the RFC patch yourself, instructions
> here:
>
> https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches
>
Signed-off-by: Lee Smith <wink@technolu.st>
I'll get an email out later this afternoon, if you get there first,
please feel free :).
> > I'd be happy to continue to try to understand why this is this case.
> > It sounds like Stephen isn't seeing these issues on 5.10 rc6 with the
> > single msi patch+reverting that one commit. I can try to give that a
> > shot if it'd produce something useful.
>
> Yes, being able to give datapoints what affects this bug is very helpful
> to track down it.
>
Ok, I'll try to rebuild to that configuration later today and report back.
> > Kalle - a couple quick questions, in the driver comments the M2 state
> > is loosely documented as a low power mode. Why would it transition to
> > that while on charger/plugging in, but stay in M0 while on battery
> > (you can see this behavior in the videos I linked previously)?
> > Naively I would've expected the opposite behavior.
>
> I would have expected the same as well, it does sound strange or we are
> misunderstanding something. I'll try to find out why it's so. But if you
> learn more, please do let me know.
>
Will do.
> > Also, is there any way to prevent that transition other than my brute
> > force? It seems on battery the 'nominal' state for it is M0, I'm not
> > sure what the effect of it being left in this M1 state really is even
> > though there's nothing observable. Lastly, any thoughts as to why it
> > seems that transition causes the EE state to become invalid?
>
> TBH I'm not very familiar with MHI, you seem to already know it much
> more better than I do :) I'll include more folks to the thread later,
> hopefully they can help.
>
Thanks!
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2020-12-12 11:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 17:38 ath11k: QCA6390 on Dell XPS 13 and kernel crashes Mitchell Nordine
2020-12-06 17:53 ` wi nk
2020-12-06 21:45 ` wi nk
2020-12-07 1:17 ` wi nk
2020-12-07 14:45 ` Mitchell Nordine
2020-12-07 17:01 ` wi nk
2020-12-09 1:52 ` wi nk
2020-12-09 9:43 ` wi nk
2020-12-09 15:28 ` wi nk
2020-12-09 15:35 ` Kalle Valo
2020-12-09 15:39 ` wi nk
2020-12-09 15:50 ` wi nk
2020-12-09 15:50 ` Kalle Valo
2020-12-09 15:55 ` wi nk
2020-12-09 21:46 ` wi nk
2020-12-11 12:28 ` wi nk
2020-12-12 5:37 ` Kalle Valo
2020-12-12 11:46 ` wi nk [this message]
2020-12-12 23:29 ` wi nk
2020-12-13 0:03 ` wi nk
2020-12-13 0:59 ` Mitchell Nordine
2020-12-13 22:09 ` Stephen Liang
2020-12-16 8:50 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-12-02 23:49 Stephen Liang
2020-12-09 15:09 ` Kalle Valo
2020-12-10 3:07 ` Stephen Liang
2020-12-10 7:37 ` Stephen Liang
2020-11-30 16:55 Kalle Valo
2020-11-30 17:02 ` wi nk
2020-12-01 10:17 ` wi nk
2020-12-05 19:17 ` wi nk
2020-12-06 8:05 ` wi nk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHUdJJUQmRkh2vAFksvnSqwN5hk58O8Smrf_-PSfwaJwC+D2CQ@mail.gmail.com \
--to=wink@technolu.st \
--cc=ath11k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=mail@mitchellnordine.com \
--cc=stephenliang7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).