From: Wen Gong <wgong@codeaurora.org>
To: Thomas Pedersen <thomas@adapt-ip.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
ath11k@lists.infradead.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons
Date: Wed, 09 Dec 2020 10:48:21 +0800 [thread overview]
Message-ID: <b64d2f6db4464c9ea53a4e29af8332af@codeaurora.org> (raw)
In-Reply-To: <bc3e532c5d21ac5d703de41d4144cf7d@adapt-ip.com>
On 2020-12-09 02:19, Thomas Pedersen wrote:
> Hi Wen,
>
> On 2020-12-07 23:44, Wen Gong wrote:
>> On 2020-09-22 10:28, Thomas Pedersen wrote:
>>> S1G beacons are 802.11 Extension Frames, so the fixed
>>> header part differs from regular beacons.
>>>
>>> Add a handler to process S1G beacons and abstract out the
>>> fetching of BSSID and element start locations in the
>>> beacon body handler.
>>>
>>> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
>>> ---
>>> net/mac80211/ieee80211_i.h | 4 ++
>>> net/mac80211/iface.c | 5 +++
>>> net/mac80211/mlme.c | 84
>>> +++++++++++++++++++++++++++++---------
>>> net/mac80211/rx.c | 84
>>> ++++++++++++++++----------------------
>>> net/mac80211/util.c | 52 +++++++++++++++++++++++
>>> 5 files changed, 162 insertions(+), 67 deletions(-)
>>>
>> ...
>>> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct
>>> ieee80211_rx_data *rx)
>>> }
>>> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) {
>>> sta->rx_stats.last_rx = jiffies;
>>> - } else if (!is_multicast_ether_addr(hdr->addr1)) {
>>> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
>>> + is_multicast_ether_addr(hdr->addr1)) {
>> is this a typo mistake?
>> it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==>
>> is_multicast_ether_addr)
>
> Yes that does look like a typo, it should be:
>
> } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
> !is_multicast_ether_addr(hdr->addr1)) {
>
> (because is_multicast_ether_addr() evaluates to true for s1g beacons).
>
> Do you have a patch or would you like me to send a fixup?
Yes, I have a patch for it.
I will send it.
>
> Thanks,
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2020-12-09 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200922022818.15855-1-thomas@adapt-ip.com>
[not found] ` <20200922022818.15855-15-thomas@adapt-ip.com>
[not found] ` <af51dd8e9dea2961546a502d9090d1a7@codeaurora.org>
2020-11-23 8:39 ` [PATCH v4 14/17] mac80211: support S1G association Wen Gong
[not found] ` <20200922022818.15855-14-thomas@adapt-ip.com>
2020-12-08 7:44 ` [PATCH v4 13/17] mac80211: receive and process S1G beacons Wen Gong
2020-12-08 18:19 ` Thomas Pedersen
2020-12-09 2:48 ` Wen Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64d2f6db4464c9ea53a4e29af8332af@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@adapt-ip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).