From: "Michael Büsch" <m@bues.ch>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs_emit
Date: Thu, 14 Mar 2024 19:32:15 +0100 [thread overview]
Message-ID: <20240314193215.74aac927@barney> (raw)
In-Reply-To: <20240314094823.1324898-2-lizhijian@fujitsu.com>
[-- Attachment #1.1: Type: text/plain, Size: 768 bytes --]
On Thu, 14 Mar 2024 17:48:22 +0800
Li Zhijian <lizhijian@fujitsu.com> wrote:
> case B43legacy_INTERFMODE_NONE:
> - count = snprintf(buf, PAGE_SIZE, "0 (No Interference"
> - " Mitigation)\n");
> + count = sysfs_emit(buf, "0 (No Interference" " Mitigation)\n");
> break;
> if (wldev->short_preamble)
> - count = snprintf(buf, PAGE_SIZE, "1 (Short Preamble"
> - " enabled)\n");
> + count = sysfs_emit(buf, "1 (Short Preamble" " enabled)\n");
> else
> - count = snprintf(buf, PAGE_SIZE, "0 (Short Preamble"
> - " disabled)\n");
> + count = sysfs_emit(buf, "0 (Short Preamble" " disabled)\n");
>
Please either leave the line break in place, or remove the string continuation.
--
Michael Büsch
https://bues.ch/
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
next prev parent reply other threads:[~2024-03-14 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240314094823.1324898-1-lizhijian@fujitsu.com>
2024-03-14 9:48 ` [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs_emit Li Zhijian
2024-03-14 18:08 ` Larry Finger
2024-03-14 18:32 ` Michael Büsch [this message]
2024-03-15 1:16 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314193215.74aac927@barney \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).