From: Johannes Berg <johannes@sipsolutions.net>
To: Masashi Honma <masashi.honma@gmail.com>
Cc: backports@vger.kernel.org
Subject: Re: Failed to backport from from Linux 4.4 drivers to Linux 3.10.108
Date: Tue, 08 May 2018 11:08:23 +0200 [thread overview]
Message-ID: <1525770503.14830.2.camel@sipsolutions.net> (raw)
In-Reply-To: <a6942432-8895-fa56-5a37-a232b99c38fc@gmail.com> (sfid-20180508_105343_655114_35417EBF)
On Tue, 2018-05-08 at 17:53 +0900, Masashi Honma wrote:
> I am using linux-4.4.y branch of backports.
> Do you mean older branch (like linux-4.2.y or linux-3.19.y or something)
> should be used ?
No, that should be OK then.
> > No, looks fine - perhaps your spatch version isn't right? What version
> > do you have,
>
> I am using a spatch binary build with latest git source because the
> package is not enough fresh to build the backports. The version is this.
>
> commit f9d474787c57f1d3cc3a73217e0f5d14ed958631
> Author: julia <julia.lawall@lip6.fr>
> Date: Mon Apr 30 08:10:06 2018 +0200
>
> make pragmas more flexible, improve positioning of eoln when pragma
> at the end of a file
>
> > and what does it say if you run
> >
> > mkdir /tmp/xyz && spatch --sp-file .../genl-const.cocci --dir /tmp/xyz
> >
> > or something like that?
>
> This is the result.
>
> ------------------
> $ mkdir /tmp/xyz && spatch --sp-file
> ./patches/collateral-evolutions/network/0027-genl-const/genl-const.cocci
> --dir /tmp/xyz
> init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h
> meta: parse error:
> File
> "./patches/collateral-evolutions/network/0027-genl-const/genl-const.cocci",
> line 2, column 10, charpos = 13
> around = '__genl_const',
> whole content = attribute __genl_const;
> ------------------
Yeah, thought so. You actually need to change the syntax here a bit, I
don't remember but you can search the mailing list here for the details.
Look for "Parse error with genl-const.cocci".
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2018-05-08 9:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 3:05 Failed to backport from from Linux 4.4 drivers to Linux 3.10.108 Masashi Honma
2018-05-08 9:09 ` Johannes Berg
2018-05-08 8:53 ` Masashi Honma
2018-05-08 9:08 ` Johannes Berg [this message]
2018-05-08 21:42 ` Masashi Honma
2018-05-09 7:21 ` Masashi Honma
2018-05-09 7:24 ` Johannes Berg
2018-05-09 7:54 ` Johannes Berg
2018-05-09 8:07 ` Masashi Honma
2018-05-09 8:12 ` Johannes Berg
2018-05-09 8:51 ` Masashi Honma
2018-05-09 9:03 ` Johannes Berg
2018-05-09 9:16 ` Masashi Honma
2018-05-09 9:24 ` Masashi Honma
2018-05-09 9:25 ` Johannes Berg
2018-05-09 14:19 ` Steve deRosier
2018-05-09 18:49 ` Arend van Spriel
2018-05-09 19:27 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525770503.14830.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).