From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from verein.lst.de ([213.95.11.211]:42703 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758281AbcHYHpa (ORCPT ); Thu, 25 Aug 2016 03:45:30 -0400 Date: Thu, 25 Aug 2016 09:43:13 +0200 From: Christoph Hellwig To: "Luis R. Rodriguez" Cc: Cristina Moraru , "vegard.nossum@gmail.com" , Valentin Rothberg , Hannes Reinecke , Sam Ravnborg , Michal Marek , linux-kernel@vger.kernel.org, teg@jklm.no, kay@vrfy.org, rusty@rustcorp.com.au, akpm@linux-foundation.org, backports@vger.kernel.org, Guenter Roeck , Greg Kroah-Hartman , "rafael.j.wysocki" , Dmitry Torokhov , Takashi Iwai , Christoph Hellwig , Mauro Carvalho Chehab , Johannes Berg , Hauke Mehrtens , Paul Bolle , Paul Gortmaker , Alexey Khoroshilov , Sathya Prakash Veerichetty , "Martin K. Petersen" , Laurence Oberman , Johannes Thumshirn , Tejun Heo , Jej B , Theodore Ts'o , danijons@student.chalmers.se, Andrzej Wasowski Subject: Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute Message-ID: <20160825074313.GC18622@lst.de> (sfid-20160825_094748_923246_B1A112AD) References: <1471462023-119645-1-git-send-email-cristina.moraru09@gmail.com> <20160818175505.GM3296@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160818175505.GM3296@wotan.suse.de> Sender: backports-owner@vger.kernel.org List-ID: The idea seems useful, but I reallt don't like the 'reverse-engineering' approach. If we want to this properly from the ground up we should just split out our CONFIG_ SYMBOLS into MODULE_* - builds exactly one module (tristate, or maybe also as a built-in only one, then like a bool) CONFIG_* - just bool, MODULE_ may depend on it, too. The other nice thing is that we could probably fold most of the Makefiles into Kconfig using that methods as well, by listing the objectes required for a module, e.g. module NVME_TARGET tristate "NVMe Target support" depends on BLOCK depends on CONFIGFS_FS name nvmet objects core.o configfs.o admin-cmd.o io-cmd.o fabrics-cmd.o objects discovery.o module NVME_TARGET_LOOP tristate "NVMe loopback device support" depends on BLK_DEV_NVME depends on NVME_TARGET select NVME_FABRICS select SG_POOL name nvme-loop objects loop.o -- To unsubscribe from this list: send the line "unsubscribe backports" in