From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, Hauke Mehrtens <hauke@hauke-m.de>
Cc: backports@vger.kernel.org
Subject: Re: backports spatch question
Date: Thu, 01 Jul 2021 23:40:02 +0200 [thread overview]
Message-ID: <84336f24b55f6ef407511235a90af4b24a8488ce.camel@sipsolutions.net> (raw)
In-Reply-To: <e26b0d55-8662-ecf7-6630-ac23a99374b5@candelatech.com>
On Thu, 2021-07-01 at 14:39 -0700, Ben Greear wrote:
> Hello,
>
> I'm trying to get backports to work against my 5.13 kernel. I'm executing
> this attempt on a Fedora-34 system, freshly updated.
>
> I am stuck on an spatch thing:
>
> [greearb@v-f34-64 backports]$ mkdir /tmp/x
> [greearb@v-f34-64 backports]$ spatch --sp-file patches/0049-no-pfmemalloc/no-pfmemalloc.cocci --dir /tmp/x
> init_defs_builtins: /usr/lib64/coccinelle/standard.h
> minus: parse error:
> File "patches/0049-no-pfmemalloc/no-pfmemalloc.cocci", line 7, column 4, charpos = 90
> around = 'page_is_pfmemalloc',
> whole content = || page_is_pfmemalloc(page)
>
>
> [greearb@v-f34-64 backports]$ cat patches/0049-no-pfmemalloc/no-pfmemalloc.cocci
> @r1@
> struct page *page;
> expression E1;
> @@
> return E1
> +#if LINUX_VERSION_IS_GEQ(3,6,0)
> || page_is_pfmemalloc(page)
> +#endif /* if LINUX_VERSION_IS_GEQ(3,6,0) */
> ;
>
>
> Any idea how to fix this?
What's your spatch version on that system?
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next parent reply other threads:[~2021-07-01 21:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e26b0d55-8662-ecf7-6630-ac23a99374b5@candelatech.com>
2021-07-01 21:40 ` Johannes Berg [this message]
2021-07-01 21:40 ` backports spatch question Ben Greear
2021-07-01 21:51 ` Johannes Berg
2021-07-01 22:33 ` Ben Greear
2021-07-01 22:55 ` Ben Greear
2021-07-05 17:47 ` Ben Greear
2021-07-05 17:55 ` Johannes Berg
2021-07-05 19:10 ` Ben Greear
2021-07-05 19:14 ` Johannes Berg
2021-07-05 19:17 ` Ben Greear
2021-07-05 19:19 ` Johannes Berg
2021-07-05 19:26 ` Ben Greear
2021-07-05 19:26 ` Johannes Berg
2021-07-05 19:32 ` Ben Greear
2021-07-05 19:32 ` Johannes Berg
2021-07-05 19:38 ` Ben Greear
2021-07-05 20:07 ` Ben Greear
2021-07-05 20:30 ` Ben Greear
2021-07-06 6:41 ` Johannes Berg
2021-07-06 13:24 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84336f24b55f6ef407511235a90af4b24a8488ce.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=greearb@candelatech.com \
--cc=hauke@hauke-m.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).