From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Winnie Chang <winnie.chang@cypress.com>,
backports@vger.kernel.org
Cc: chln@cypress.com
Subject: Re: [PATCH] backports: rename *-asn1.[ch] to *.asn1.[ch]
Date: Thu, 19 Apr 2018 16:02:33 +0800 [thread overview]
Message-ID: <91215546-664c-4714-9a36-aaf6edc35429@cypress.com> (raw)
In-Reply-To: <1524123197.3024.13.camel@sipsolutions.net>
On 04/19/2018 3:33, Johannes Berg wrote:
> On Thu, 2018-04-19 at 01:11 -0500, Winnie Chang wrote:
>> linux-stable 4fa8bc949de11c99ee2433c602d43f87c452f4f2 renamed
>> *-asn1.[ch] files to *.asn1.[ch]. Make the corresponding change
>> for backports.
>
> Does it matter? I mean, I don't really mind the patch, but I also see
> little reason for it?
Johannes,
Thanks for reviewing.
The linux-stable file rename has caused build failure. It's because
backports pulls kernel pkcs7_parser.c, which includes the renamed header
file pkcs7.asn1.h, while our corresponding copy in backports.git still
has the old name pkcs7-asn1.h.
Here's the copy-list line that pulls pkcs_parser.c:
crypto/asymmetric_keys/pkcs7_parser.c -> compat/verification/pkcs7_parser.c
Chi-hsien Lin
>
> johannes
> --
> To unsubscribe from this list: send the line "unsubscribe backports" in
> .
>
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2018-04-19 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 6:11 [PATCH] backports: rename *-asn1.[ch] to *.asn1.[ch] Winnie Chang
2018-04-19 7:33 ` Johannes Berg
2018-04-19 8:02 ` Chi-Hsien Lin [this message]
2018-04-19 8:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91215546-664c-4714-9a36-aaf6edc35429@cypress.com \
--to=chi-hsien.lin@cypress.com \
--cc=backports@vger.kernel.org \
--cc=chln@cypress.com \
--cc=johannes@sipsolutions.net \
--cc=winnie.chang@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).