b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: fix multicast counter when purging originators
Date: Sun, 16 Nov 2014 16:55:02 +0800	[thread overview]
Message-ID: <12208952.53ie7oUJTC@diderot> (raw)
In-Reply-To: <1414644048-5792-3-git-send-email-linus.luessing@c0d3.blue>

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On Thursday 30 October 2014 05:40:47 Linus Lüssing wrote:
> When purging an orig_node we should only decrease counter tracking the
> number of nodes without multicast optimizations support if it was
> increased through this orig_node before.
> 
> A not yet quite initialized orig_node (meaning it did not have its turn
> in the mcast-tvlv handler so far) which gets purged would not adhere to
> this and will lead to a counter imbalance.
> 
> Fixing this by adding a check whether the orig_node is mcast-initalized
> before decreasing the counter in the mcast-orig_node-purging routine.
> 
> Introduced by 77ec494490d60d89b42cd01d5dbf8dee04503623
> ("batman-adv: Announce new capability via multicast TVLV")
> 
> Reported-by: Tobias Hachmer <tobias@hachmer.de>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  multicast.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied in revision 9e9d48e.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2014-11-16  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  4:40 [B.A.T.M.A.N.] [PATCHv2 0/2] fixes for multicast counter imbalances Linus Lüssing
2014-10-30  4:40 ` [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: fix counter for multicast supporting nodes Linus Lüssing
2014-11-16  8:53   ` Marek Lindner
2014-10-30  4:40 ` [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: fix multicast counter when purging originators Linus Lüssing
2014-11-16  8:55   ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12208952.53ie7oUJTC@diderot \
    --to=mareklindner@neomailbox.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).