On Friday 26 December 2014 12:41:20 Markus Pargmann wrote:
> +static int batadv_iv_ogm_neigh_diff(struct batadv_neigh_node *neigh1,
> +                                   struct batadv_hard_iface *if_outgoing1,
> +                                   struct batadv_neigh_node *neigh2,
> +                                   struct batadv_hard_iface *if_outgoing2,
> +                                   int *diff)
>  {
>         struct batadv_neigh_ifinfo *neigh1_ifinfo, *neigh2_ifinfo;
>         uint8_t tq1, tq2;
> -       int diff;
> +       int ret;

In the success case 'ret' is never initialized or set to any specific value.
We do lack kernel doc for the newly created function 
'batadv_iv_ogm_neigh_diff'.

Cheers,
Marek