From: Antonio Quartulli <ordex@autistici.org>
To: "B.A.T.M.A.N" <b.a.t.m.a.n@lists.open-mesh.org>
Subject: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: the skb has not to be freed in recv_roam_adv()
Date: Thu, 16 Jun 2011 00:32:24 +0200 [thread overview]
Message-ID: <1308177145-21191-1-git-send-email-ordex@autistici.org> (raw)
In-Reply-To: <201106152056.18072.lindner_marek@yahoo.de>
In recv_roam_adv(), in case of error the skb is freed and then
NET_RX_DROP is returned. This makes the caller function wrongly invoke
kfree_skb() again. To avoid this double free recv_tt_query() has to
always return NET_RX_DROP and not to free the skb.
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
routing.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/routing.c b/routing.c
index 2222288..0ce090c 100644
--- a/routing.c
+++ b/routing.c
@@ -1259,7 +1259,6 @@ int recv_roam_adv(struct sk_buff *skb, struct hard_iface *recv_if)
struct roam_adv_packet *roam_adv_packet;
struct orig_node *orig_node;
struct ethhdr *ethhdr;
- int ret = NET_RX_DROP;
/* drop packet if it has not necessary minimum size */
if (unlikely(!pskb_may_pull(skb, sizeof(struct roam_adv_packet))))
@@ -1297,10 +1296,9 @@ int recv_roam_adv(struct sk_buff *skb, struct hard_iface *recv_if)
bat_priv->tt_poss_change = true;
orig_node_free_ref(orig_node);
- ret = NET_RX_SUCCESS;
out:
- kfree(skb);
- return ret;
+ /* returning NET_RX_DROP will make the caller function kfree the skb */
+ return NET_RX_DROP;
}
/* find a suitable router for this originator, and use
--
1.7.3.4
next prev parent reply other threads:[~2011-06-15 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 16:01 [B.A.T.M.A.N.] [PATCH] batman-adv: skbs have to be freed using kfree_skb() Antonio Quartulli
2011-06-15 18:56 ` Marek Lindner
2011-06-15 22:32 ` Antonio Quartulli [this message]
2011-06-16 10:16 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: the skb has not to be freed in recv_roam_adv() Marek Lindner
2011-06-15 22:32 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: skbs have to be freed using kfree_skb() Antonio Quartulli
2011-06-16 10:22 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308177145-21191-1-git-send-email-ordex@autistici.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).