From: lemoer <freifunk@irrelefant.net>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs
Date: Wed, 9 May 2018 23:34:18 +0200 [thread overview]
Message-ID: <1da124b0-ea99-4d3a-3d55-fbaacd3754f7@irrelefant.net> (raw)
In-Reply-To: <2913969.huEjgAY5Wz@sven-edge>
On 05/09/2018 10:38 PM, Sven Eckelmann wrote:
> Wait. When it is a problem of an intermediate node that doesn't have (for
> whatever reason) not a valid copy of the entries, shouldn't the intermediate
> node just ignore the request and not answer it?
Yes. It's forwarded here
https://elixir.bootlin.com/linux/v4.16.8/source/net/batman-adv/translation-table.c#L4245
if the check here
https://elixir.bootlin.com/linux/v4.16.8/source/net/batman-adv/translation-table.c#L3199
fails. I also wrote a debug patch which adds counters which
differentiate between crc misses, ttvn misses and other misses. I can
also prepare them, when it is desired.
> And the next thing is that your commit message is talking about OGMs all the
> time. But the OGM TVLV are not filled by the
> batadv_tt_prepare_tvlv_global_data but by the
> batadv_tt_prepare_tvlv_local_data. I am unable to find out what you actually
> doing here and why you do it.
Yes. IIRC the checksums in the OGMs are actually causing the issue. The
checksums in the TT responses are not evaluated for now.
Kind regards,
Leonardo Mörlein
next prev parent reply other threads:[~2018-05-09 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:55 [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received Leonardo Mörlein
2018-05-07 6:32 ` Sven Eckelmann
2018-05-07 8:06 ` me
2018-05-07 10:23 ` Sven Eckelmann
2018-05-08 8:45 ` Sven Eckelmann
2018-05-09 14:08 ` Marek Lindner
2018-05-09 16:06 ` [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs Marek Lindner
2018-05-09 17:21 ` Sven Eckelmann
2018-05-09 18:20 ` Sven Eckelmann
2018-05-09 20:38 ` Sven Eckelmann
2018-05-09 21:34 ` lemoer [this message]
2018-05-10 9:12 ` Antonio Quartulli
2018-05-10 10:28 ` Marek Lindner
2018-05-10 14:41 ` [B.A.T.M.A.N.] [RFC v2] " Marek Lindner
2018-05-10 15:50 ` Sven Eckelmann
2018-05-11 15:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1da124b0-ea99-4d3a-3d55-fbaacd3754f7@irrelefant.net \
--to=freifunk@irrelefant.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).