From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup
Date: Tue, 14 Jul 2009 15:38:05 +0200 [thread overview]
Message-ID: <200907141538.10902.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <20090714132004.GN19071@ma.tech.ascom.ch>
[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]
> On Tue, Jul 14, 2009 at 03:09:26PM +0200, Andrew Lunn wrote:
> What are peoples opinion about this? Should i spend a little time
> cleaning up all the files? Some code needs refactoring a little, to
> reducing the nesting, creating more helper functions, but mostly its
> white space changes. However such changes can cause pain when trying
> to merge in other work people who diff's are against before the
> cleanup. Does anybody have any major patches?
I am not a batman-adv developer but I am definitely pro cleanup. There aren't
many known people which write code against the current version who wants to
merge with trunk. And I think it is better to remove the clutter now instead
of waiting until more "chaos" was created.
You should check out the scripts inside Andrew Morton's kernel[1,2]. I checked
them some time ago and they were far better then the ones inside the vanilla
kernel. I think most of that changes are already merged, but I don't know in
which version.
[1] http://userweb.kernel.org/~akpm/mmotm/
[2] git://git.zen-sources.org/zen/mmotm.git
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2009-07-14 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 13:09 [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup Andrew Lunn
2009-07-14 13:20 ` Andrew Lunn
2009-07-14 13:32 ` Antoine van Gelder
2009-07-14 13:57 ` [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanupy Andrew Lunn
2009-07-14 13:38 ` Sven Eckelmann [this message]
2009-07-14 14:48 ` [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907141538.10902.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).