From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Linus L??ssing <linus.luessing@ascom.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/11] batman-adv: Send neighbor discovery packets
Date: Sat, 15 Jan 2011 14:53:13 +0100 [thread overview]
Message-ID: <20110115135313.GQ23716@lunn.ch> (raw)
In-Reply-To: <1294966794-17780-4-git-send-email-linus.luessing@ascom.ch>
> diff --git a/batman-adv/ndp.c b/batman-adv/ndp.c
> index 60631b0..3269d67 100644
> --- a/batman-adv/ndp.c
> +++ b/batman-adv/ndp.c
> @@ -49,10 +49,21 @@ static void ndp_send(struct work_struct *work)
> struct batman_if *batman_if = container_of(work, struct batman_if,
> ndp_wq.work);
> struct bat_priv *bat_priv = netdev_priv(batman_if->soft_iface);
> + struct batman_packet_ndp *ndp_packet;
> + struct sk_buff *skb;
> +
> + skb = skb_copy(batman_if->ndp_skb, GFP_ATOMIC);
> + ndp_packet = (struct batman_packet_ndp *)skb->data;
Hi Linus
You should check the returned skb. It could be NULL if the system is
out of memory.
Andrew
next prev parent reply other threads:[~2011-01-15 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 0:59 [B.A.T.M.A.N.] NDP patches v5 Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 01/11] batman-adv: Rename packet type / structure / functions for OGMs Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 02/11] batman-adv: Adding workqueue for new ndp packets Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 03/11] batman-adv: Send neighbor discovery packets Linus Lüssing
2011-01-15 13:53 ` Andrew Lunn [this message]
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 04/11] batman-adv: Creating neighbor structures, updating LQs Linus Lüssing
2011-01-15 14:14 ` Andrew Lunn
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 05/11] batman-adv: Purge outdated ndp neighbours Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 06/11] batman-adv: Adding ndp debugfs output Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 07/11] batman-adv: Adding batman_if specific sysfs wrapper macros for UINT Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 08/11] batman-adv: Adding sysfs parameter for ndp interval Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 09/11] batman-adv: Use local tq values determined by NDP on OGMs Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 10/11] batman-adv: Use rcu locking + ref-counting for neigh_list Linus Lüssing
2011-01-14 0:59 ` [B.A.T.M.A.N.] [PATCH 11/11] batman-adv: Adding sysfs ABI documentation for ndp_interval Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115135313.GQ23716@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@ascom.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).