From: Andreas Pape <APape@phoenixcontact.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: [B.A.T.M.A.N.] Antwort: Re: Antwort: Re: Antwort: Antwort: Re: Antwort: Re: Question concerning batman-adv bug #173 "Mesh packets on bat0"
Date: Thu, 19 Feb 2015 11:28:24 +0100 [thread overview]
Message-ID: <OFA96D7726.B38F8A68-ONC1257DF1.0038B77B-C1257DF1.003988B0@phoenixcontact.com> (raw)
In-Reply-To: <1485649.labZ4ZGvMV@voltaire>
I started with a freshly unpacked source code of the 2014.4.0 release and
applied only your latest patch.
As expected from the tests done so far with the old kernel effectively not
calling netdev_set_master allows the usage of the latest batman-adv
version in combination with older kernels (at least the 2.6.32 I tested
with).
I think this patch is worth to be integrated into the next batman-adv
version.
Regards,
Andreas
"B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> schrieb am
19.02.2015 10:40:34:
> Von: Marek Lindner <mareklindner@neomailbox.ch>
> An: The list for a Better Approach To Mobile Ad-hoc Networking
> <b.a.t.m.a.n@lists.open-mesh.org>,
> Datum: 19.02.2015 10:42
> Betreff: Re: [B.A.T.M.A.N.] Antwort: Re: Antwort: Antwort: Re:
> Antwort: Re: Question concerning batman-adv bug #173 "Mesh packets on
bat0"
> Gesendet von: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org>
>
> On Thursday, February 19, 2015 09:31:08 Andreas Pape wrote:
> > the problem seems to be a little bit more complex. Your latest patch
does
> > not solve the problem.
> >
> > But I found out, that commenting out the following line in your patch
> > makes bat0 work:
> >
> > slave->master = master;
> >
> > But as this is the core of "enslaving" a device to a master device,
this
> > breaks the complete concept behind this I guess (I'm not a skilled
kernel
> > developer). From this I conclude that there might be a bug somewhere
> > deeper in the kernel version I use. I don't want to give up too
early,
> > but it looks a little bit as if this "enslaving concept using rtnl"
might
> > not be usable in these older kernels. What do you think?
>
> Please try the attached patch instead. This time we are replacing
> the function
> with our own function doing nothing at all. The net_dev->master
> variable seems
> to be reserved for interface bonding and shouldn't be touched at allon
these
> ancient kernels.
>
> Cheers,
> Marek
> [Anhang "0001-batman-adv-ignore-netdev_set_master-calls-on-
> kernels.patch" gelöscht von Andreas Pape/Phoenix Contact] [Anhang
> "signature.asc" gelöscht von Andreas Pape/Phoenix Contact]
next prev parent reply other threads:[~2015-02-19 10:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 7:35 [B.A.T.M.A.N.] Question concerning batman-adv bug #173 "Mesh packets on bat0" Andreas Pape
2015-02-18 11:26 ` Marek Lindner
2015-02-18 12:28 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2015-02-18 13:55 ` Marek Lindner
2015-02-18 14:56 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2015-02-18 15:22 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2015-02-18 15:45 ` Marek Lindner
2015-02-18 16:10 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2015-02-19 4:15 ` Marek Lindner
2015-02-19 8:31 ` Andreas Pape
2015-02-19 9:40 ` Marek Lindner
2015-02-19 10:28 ` Andreas Pape [this message]
2015-02-19 10:36 ` [B.A.T.M.A.N.] Antwort: " Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFA96D7726.B38F8A68-ONC1257DF1.0038B77B-C1257DF1.003988B0@phoenixcontact.com \
--to=apape@phoenixcontact.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).