b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org, Jiri Pirko <jiri@resnulli.us>,
	kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] batman-adv: Start new development cycle
Date: Tue, 7 Feb 2023 11:02:58 +0200	[thread overview]
Message-ID: <Y+ITwsu5Lg5DxgRt@unreal> (raw)
In-Reply-To: <8520325.EvYhyI6sBW@ripper>

On Fri, Feb 03, 2023 at 10:38:07AM +0100, Sven Eckelmann wrote:
> On Friday, 3 February 2023 09:29:50 CET Jiri Pirko wrote:
> [...]
> > Why kernel version is not enough for you? My point is, why to maintain
> > internal driver version alongside with the kernel version?
> [...]
> > >Also note that we can't do a simple kernel version to year
> > >notation mapping in userspace in batctl. OpenWrt uses the most
> > >recent Linux LTS release. But might feature a backport of a more
> > >recent batman-adv which is newer than the one this stable kernel
> > >would provide. Or people also often use Debian stable but compile
> > >and use the latest batman-adv version with it.
> > 
> > Yeah, for out of tree driver, have whatever.
> 
> A while back, my personal opinion changed after there were various Linux 
> developers/maintainers were trying to either remove it or wondering about this 
> bump. The idea which I've proposed was to:
> 
> * still ship the "backports" like out-of-tree tarball with a module version - 
>   but directly in its "compat" code
> * continue to use in projects (which for whatever reason cannot use the in-
>   kernel implementation) a version which represents their upstream backports 
>   tarball + their (patch) revision: Something like "2022.0-openwrt-7"
> * for the in-kernel module, just return either 
> 
>   - remove the version information completely from the kernel module 
>     MODULE_VERSION + drop BATADV_ATTR_VERSION + modifying batctl to fetch that 
>     from uname(). But of course, that would break old batctl versions [1]
>   - or by setting BATADV_SOURCE_VERSION to UTS_RELEASE (+suffix?) or 
>     UTS_VERSION
> 
> 
> But this wasn't well received when mentioning it to Simon+Linus (but I could 
> misremember the persons involved here).

In cases where you can prove real userspace breakage, we simply stop to
update module versions.

Thanks

> 
> Kind regards,
> 	Sven
> 
> [1] https://lore.kernel.org/r/20201205085604.1e3fcaee@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com


  reply	other threads:[~2023-02-07  9:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 10:21 [PATCH 0/5] pull request for net-next: batman-adv 2023-01-27 Simon Wunderlich
2023-01-27 10:21 ` [PATCH 1/5] batman-adv: Start new development cycle Simon Wunderlich
2023-01-30  7:40   ` patchwork-bot+netdevbpf
2023-01-30 14:55   ` Jiri Pirko
2023-02-02 18:44     ` Linus Lüssing
2023-02-03  8:29       ` Jiri Pirko
2023-02-03  9:38         ` Sven Eckelmann
2023-02-07  9:02           ` Leon Romanovsky [this message]
2023-02-07  9:50             ` Sven Eckelmann
2023-02-07 10:41               ` Leon Romanovsky
2023-02-07 10:57                 ` Sven Eckelmann
2023-02-07 11:20                   ` Leon Romanovsky
2023-01-27 10:21 ` [PATCH 2/5] batman-adv: Drop prandom.h includes Simon Wunderlich
2023-01-27 10:21 ` [PATCH 3/5] batman-adv: Fix mailing list address Simon Wunderlich
2023-01-27 10:21 ` [PATCH 4/5] batman-adv: mcast: remove now redundant single ucast forwarding Simon Wunderlich
2023-01-27 10:21 ` [PATCH 5/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type Simon Wunderlich
  -- strict thread matches above, loose matches on Subject: below --
2020-08-24 16:27 [PATCH 0/5] pull request for net-next: batman-adv 2020-08-24 Simon Wunderlich
2020-08-24 16:27 ` [PATCH 1/5] batman-adv: Start new development cycle Simon Wunderlich
2020-04-27 15:06 [PATCH 0/5] pull request for net-next: batman-adv 2020-04-27 Simon Wunderlich
2020-04-27 15:06 ` [PATCH 1/5] batman-adv: Start new development cycle Simon Wunderlich
2019-11-05  9:35 [PATCH 0/5] pull request for net-next: batman-adv 2019-11-05 Simon Wunderlich
2019-11-05  9:35 ` [PATCH 1/5] batman-adv: Start new development cycle Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+ITwsu5Lg5DxgRt@unreal \
    --to=leon@kernel.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).