bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hou Tao <houtao@huaweicloud.com>
To: Andrew Werner <awerner32@gmail.com>, bpf@vger.kernel.org
Cc: kernel-team@dataexmachina.dev, alexei.starovoitov@gmail.com
Subject: Re: [PATCH bpf-next v2] selftests/bpf: improve ringbuf benchmark output
Date: Fri, 21 Jul 2023 20:57:14 +0800	[thread overview]
Message-ID: <1499e329-8132-3233-e3ed-79ef0bcb591c@huaweicloud.com> (raw)
In-Reply-To: <20230719201533.176702-1-awerner32@gmail.com>



On 7/20/2023 4:15 AM, Andrew Werner wrote:
> The ringbuf benchmarks print headers for each section of benchmarks.
> The naming conventions lead a user of the benchmarks to some confusion.
> This change is a cosmetic update to the output of that benchmark; no
> changes were made to what the script actually executes.
>
> The back-to-back exploration of sample rates for Perfbuf and Ringbuf
> have been combined into a single section.
>
> Some of the variables in the script were renamed for clarity; b is
> always a benchmark name, s is a sampling rate, n is a number of
> producers. Before the change, b was the only variable.
>
> After:
> ```
> Parallel producer
> =================
> rb-libbpf            43.072 ± 0.165M/s (drops 0.940 ± 0.016M/s)
> rb-custom            20.274 ± 0.442M/s (drops 0.000 ± 0.000M/s)
> pb-libbpf            1.480 ± 0.015M/s (drops 0.000 ± 0.000M/s)
> pb-custom            1.492 ± 0.023M/s (drops 0.000 ± 0.000M/s)
>
......
>
> ```
>
> Signed-off-by: Andrew Werner <awerner32@gmail.com>

Acked-by: Hou Tao <houtao1@huawei.com>


      reply	other threads:[~2023-07-21 12:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 20:15 [PATCH bpf-next v2] selftests/bpf: improve ringbuf benchmark output Andrew Werner
2023-07-21 12:57 ` Hou Tao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499e329-8132-3233-e3ed-79ef0bcb591c@huaweicloud.com \
    --to=houtao@huaweicloud.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=awerner32@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=kernel-team@dataexmachina.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).